From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org, sboyd@codeaurora.org
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH] clk-gate: fix bit # check in clk_register_gate()
Date: Sat, 17 Jan 2015 22:06:51 +0000 [thread overview]
Message-ID: <54BADCFB.5010805@cogentembedded.com> (raw)
In-Reply-To: <20150117220116.22722.808@quantum>
Hello.
On 01/18/2015 01:01 AM, Mike Turquette wrote:
>> In case CLK_GATE_HIWORD_MASK flag is passed to clk_register_gate(), the bit #
>> should be no higher than 15, however the corresponding check is obviously off-
>> by-one.
>> Fixes: 045779942c04 ("clk: gate: add CLK_GATE_HIWORD_MASK")
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied to clk-next. Thanks! Is this causing a visible regression for
> you? It is not a new bug so I'd prefer to send it though clk-next unless
> something is blowing up on your end.
No, nothing, I don't even call this function (was using composite clock).
Found by just looking at the code.
>> ---
>> The patch is against Linus' repo because the 'clk-fixes' branch in Mike
>> Turquette's 'linux.git' repo at Linaro seems very outdated. BTW, the repo
>> at kernel.org specified by the MAINTAINERS file doesn't seem to exist --
>> can something be done about that?
> The clk-fixes branch at git.linaro.org is now updated and the clk tree
> at git.kernel.org is also live. Blame the holidays.
> For now they will mirror each other (and linux-next will continue to
> reference the one at git.linaro.org until 3.19 is released).
Thank you.
> Regards,
> Mike
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Mike Turquette <mturquette@linaro.org>,
linux-kernel@vger.kernel.org, sboyd@codeaurora.org
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH] clk-gate: fix bit # check in clk_register_gate()
Date: Sun, 18 Jan 2015 01:06:51 +0300 [thread overview]
Message-ID: <54BADCFB.5010805@cogentembedded.com> (raw)
In-Reply-To: <20150117220116.22722.808@quantum>
Hello.
On 01/18/2015 01:01 AM, Mike Turquette wrote:
>> In case CLK_GATE_HIWORD_MASK flag is passed to clk_register_gate(), the bit #
>> should be no higher than 15, however the corresponding check is obviously off-
>> by-one.
>> Fixes: 045779942c04 ("clk: gate: add CLK_GATE_HIWORD_MASK")
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Applied to clk-next. Thanks! Is this causing a visible regression for
> you? It is not a new bug so I'd prefer to send it though clk-next unless
> something is blowing up on your end.
No, nothing, I don't even call this function (was using composite clock).
Found by just looking at the code.
>> ---
>> The patch is against Linus' repo because the 'clk-fixes' branch in Mike
>> Turquette's 'linux.git' repo at Linaro seems very outdated. BTW, the repo
>> at kernel.org specified by the MAINTAINERS file doesn't seem to exist --
>> can something be done about that?
> The clk-fixes branch at git.linaro.org is now updated and the clk tree
> at git.kernel.org is also live. Blame the holidays.
> For now they will mirror each other (and linux-next will continue to
> reference the one at git.linaro.org until 3.19 is released).
Thank you.
> Regards,
> Mike
WBR, Sergei
next prev parent reply other threads:[~2015-01-17 22:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 14:43 [PATCH] clk-gate: fix bit # check in clk_register_gate() Sergei Shtylyov
2014-12-24 14:43 ` Sergei Shtylyov
2015-01-17 22:01 ` Mike Turquette
2015-01-17 22:01 ` Mike Turquette
2015-01-17 22:06 ` Sergei Shtylyov [this message]
2015-01-17 22:06 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BADCFB.5010805@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.