From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hanjun Guo Subject: Re: [PATCH v7 07/17] ARM64 / ACPI: Disable ACPI if FADT revision is less than 5.1 Date: Sun, 18 Jan 2015 13:49:50 +0800 Message-ID: <54BB497E.7050606@linaro.org> References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <1421247905-3749-8-git-send-email-hanjun.guo@linaro.org> <20150116143337.GA14505@red-moon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-pd0-f175.google.com ([209.85.192.175]:53312 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750710AbbARFuC (ORCPT ); Sun, 18 Jan 2015 00:50:02 -0500 Received: by mail-pd0-f175.google.com with SMTP id g10so30284220pdj.6 for ; Sat, 17 Jan 2015 21:50:01 -0800 (PST) In-Reply-To: <20150116143337.GA14505@red-moon> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Lorenzo Pieralisi Cc: Catalin Marinas , "Rafael J. Wysocki" , Olof Johansson , Arnd Bergmann , Mark Rutland , "grant.likely@linaro.org" , Will Deacon , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Mark Brown , Rob Herring , Robert Richter , Randy Dunlap , Charles Garcia-Tobin , "phoenix.liyi@huawei.com" , Timur Tabi , "suravee.suthikulpanit@amd.com" , wangyijing@huawei.com On 2015=E5=B9=B401=E6=9C=8816=E6=97=A5 22:33, Lorenzo Pieralisi wrote: > On Wed, Jan 14, 2015 at 03:04:55PM +0000, Hanjun Guo wrote: >> FADT Major.Minor version was introduced in ACPI 5.1, it is the same >> as ACPI version. >> >> In ACPI 5.1, some major gaps are fixed for ARM, such as updates in >> MADT table for GIC and SMP init, without those updates, we can not >> get the MPIDR for SMP init, and GICv2/3 related init information, so >> we can't boot arm64 ACPI properly with table versions predating 5.1. >> >> If firmware provides ACPI tables with ACPI version less than 5.1, >> OS will be messed up with those information and have no way to init > > Nit: "that information" > > or > > "...OS has no way to retrieve the configuration data that is necessar= y > to init SMP boot protocol and the GIC properly, so.." > >> smp and GIC, so disable ACPI if we get an FADT table with version >> less that 5.1. >> > > Patch should be reordered in the series and must be sequenced before > patch 5 for bisectability (that patch implements DT unflattening if A= CPI > is disabled), or squashed with previous patches. OK, I will reorder this patch set and update the change log above. Thanks Hanjun -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: hanjun.guo@linaro.org (Hanjun Guo) Date: Sun, 18 Jan 2015 13:49:50 +0800 Subject: [PATCH v7 07/17] ARM64 / ACPI: Disable ACPI if FADT revision is less than 5.1 In-Reply-To: <20150116143337.GA14505@red-moon> References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <1421247905-3749-8-git-send-email-hanjun.guo@linaro.org> <20150116143337.GA14505@red-moon> Message-ID: <54BB497E.7050606@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015?01?16? 22:33, Lorenzo Pieralisi wrote: > On Wed, Jan 14, 2015 at 03:04:55PM +0000, Hanjun Guo wrote: >> FADT Major.Minor version was introduced in ACPI 5.1, it is the same >> as ACPI version. >> >> In ACPI 5.1, some major gaps are fixed for ARM, such as updates in >> MADT table for GIC and SMP init, without those updates, we can not >> get the MPIDR for SMP init, and GICv2/3 related init information, so >> we can't boot arm64 ACPI properly with table versions predating 5.1. >> >> If firmware provides ACPI tables with ACPI version less than 5.1, >> OS will be messed up with those information and have no way to init > > Nit: "that information" > > or > > "...OS has no way to retrieve the configuration data that is necessary > to init SMP boot protocol and the GIC properly, so.." > >> smp and GIC, so disable ACPI if we get an FADT table with version >> less that 5.1. >> > > Patch should be reordered in the series and must be sequenced before > patch 5 for bisectability (that patch implements DT unflattening if ACPI > is disabled), or squashed with previous patches. OK, I will reorder this patch set and update the change log above. Thanks Hanjun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751401AbbARFuH (ORCPT ); Sun, 18 Jan 2015 00:50:07 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:45045 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbbARFuC (ORCPT ); Sun, 18 Jan 2015 00:50:02 -0500 Message-ID: <54BB497E.7050606@linaro.org> Date: Sun, 18 Jan 2015 13:49:50 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Lorenzo Pieralisi CC: Catalin Marinas , "Rafael J. Wysocki" , Olof Johansson , Arnd Bergmann , Mark Rutland , "grant.likely@linaro.org" , Will Deacon , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Jason Cooper , Marc Zyngier , Bjorn Helgaas , Mark Brown , Rob Herring , Robert Richter , Randy Dunlap , Charles Garcia-Tobin , "phoenix.liyi@huawei.com" , Timur Tabi , "suravee.suthikulpanit@amd.com" , "wangyijing@huawei.com" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [PATCH v7 07/17] ARM64 / ACPI: Disable ACPI if FADT revision is less than 5.1 References: <1421247905-3749-1-git-send-email-hanjun.guo@linaro.org> <1421247905-3749-8-git-send-email-hanjun.guo@linaro.org> <20150116143337.GA14505@red-moon> In-Reply-To: <20150116143337.GA14505@red-moon> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年01月16日 22:33, Lorenzo Pieralisi wrote: > On Wed, Jan 14, 2015 at 03:04:55PM +0000, Hanjun Guo wrote: >> FADT Major.Minor version was introduced in ACPI 5.1, it is the same >> as ACPI version. >> >> In ACPI 5.1, some major gaps are fixed for ARM, such as updates in >> MADT table for GIC and SMP init, without those updates, we can not >> get the MPIDR for SMP init, and GICv2/3 related init information, so >> we can't boot arm64 ACPI properly with table versions predating 5.1. >> >> If firmware provides ACPI tables with ACPI version less than 5.1, >> OS will be messed up with those information and have no way to init > > Nit: "that information" > > or > > "...OS has no way to retrieve the configuration data that is necessary > to init SMP boot protocol and the GIC properly, so.." > >> smp and GIC, so disable ACPI if we get an FADT table with version >> less that 5.1. >> > > Patch should be reordered in the series and must be sequenced before > patch 5 for bisectability (that patch implements DT unflattening if ACPI > is disabled), or squashed with previous patches. OK, I will reorder this patch set and update the change log above. Thanks Hanjun