From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Andy Green <andy.green@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
Eugene Krasnikov <k.eugene.e@gmail.com>
Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH 5/7] net: wireless: wcn36xx: swallow two wcn3620 IND messages
Date: Sun, 18 Jan 2015 14:47:08 +0300 [thread overview]
Message-ID: <54BB9D3C.90306@cogentembedded.com> (raw)
In-Reply-To: <20150118051105.31866.43889.stgit@114-36-241-182.dynamic.hinet.net>
Hello.
On 1/18/2015 8:11 AM, Andy Green wrote:
> WCN3620 can asynchronously send two new kinds of indication message,
> since we can't handle them just accept them quietly.
> Signed-off-by: Andy Green <andy.green@linaro.org>
> ---
> drivers/net/wireless/ath/wcn36xx/smd.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 6398693..819741c 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
[...]
> @@ -2107,6 +2109,10 @@ static void wcn36xx_ind_smd_work(struct work_struct *work)
> msg_header = (struct wcn36xx_hal_msg_header *)hal_ind_msg->msg;
>
> switch (msg_header->msg_type) {
> + case WCN36XX_HAL_COEX_IND:
> + break;
> + case WCN36XX_HAL_AVOID_FREQ_RANGE_IND:
> + break;
Can't you merge these 2 cases, so that there's only one *break*?
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Andy Green <andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Eugene Krasnikov
<k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 5/7] net: wireless: wcn36xx: swallow two wcn3620 IND messages
Date: Sun, 18 Jan 2015 14:47:08 +0300 [thread overview]
Message-ID: <54BB9D3C.90306@cogentembedded.com> (raw)
In-Reply-To: <20150118051105.31866.43889.stgit-FDDIDLfWL9/T9rR/E2HzMujRB4CPm7EUkgzjau31qRg@public.gmane.org>
Hello.
On 1/18/2015 8:11 AM, Andy Green wrote:
> WCN3620 can asynchronously send two new kinds of indication message,
> since we can't handle them just accept them quietly.
> Signed-off-by: Andy Green <andy.green-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
> drivers/net/wireless/ath/wcn36xx/smd.c | 6 ++++++
> 1 file changed, 6 insertions(+)
> diff --git a/drivers/net/wireless/ath/wcn36xx/smd.c b/drivers/net/wireless/ath/wcn36xx/smd.c
> index 6398693..819741c 100644
> --- a/drivers/net/wireless/ath/wcn36xx/smd.c
> +++ b/drivers/net/wireless/ath/wcn36xx/smd.c
[...]
> @@ -2107,6 +2109,10 @@ static void wcn36xx_ind_smd_work(struct work_struct *work)
> msg_header = (struct wcn36xx_hal_msg_header *)hal_ind_msg->msg;
>
> switch (msg_header->msg_type) {
> + case WCN36XX_HAL_COEX_IND:
> + break;
> + case WCN36XX_HAL_AVOID_FREQ_RANGE_IND:
> + break;
Can't you merge these 2 cases, so that there's only one *break*?
[...]
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-01-18 11:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 5:10 [PATCH 0/7] net: wireless: wcn36xx: add basic wcn3620 support Andy Green
2015-01-18 5:10 ` Andy Green
2015-01-18 5:10 ` [PATCH 1/7] net: wireless: wcn36xx: add wcn3620 chip type definition Andy Green
2015-01-18 5:10 ` Andy Green
2015-01-18 14:17 ` Kalle Valo
2015-01-19 0:24 ` Andy Green
2015-01-23 15:39 ` Kalle Valo
2015-01-23 15:39 ` Kalle Valo
2015-01-18 5:10 ` [PATCH 2/7] net: wireless: wcn36xx: get chip type from platform ops Andy Green
2015-01-18 8:36 ` Pat Erley
2015-01-18 8:36 ` Pat Erley
2015-01-18 5:10 ` [PATCH 3/7] net: wireless: wcn36xx: use 3680 dxe regs for 3620 Andy Green
2015-01-18 5:11 ` [PATCH 4/7] net: wireless: wcn36xx: introduce WCN36XX_HAL_AVOID_FREQ_RANGE_IND Andy Green
2015-01-27 20:01 ` Eugene Krasnikov
2015-01-27 20:57 ` Andy Green
2015-01-18 5:11 ` [PATCH 5/7] net: wireless: wcn36xx: swallow two wcn3620 IND messages Andy Green
2015-01-18 11:47 ` Sergei Shtylyov [this message]
2015-01-18 11:47 ` Sergei Shtylyov
2015-01-18 12:59 ` Andy Green
2015-01-18 5:11 ` [PATCH 6/7] net: wireless: wcn36xx: remove powersaving for wcn3620 Andy Green
2015-02-09 17:54 ` Bjorn Andersson
2015-02-09 17:54 ` Bjorn Andersson
2015-02-09 21:07 ` Andy Green
2015-02-09 21:07 ` Andy Green
[not found] ` <CAJAp7OjLDCzLYeb3LHNs1sOHWM64XZWzr46UQ2vNirH_2JibNg@mail.gmail.com>
2015-02-09 21:28 ` Andy Green
2015-02-09 21:28 ` Andy Green
2015-02-09 21:40 ` Bjorn Andersson
2015-02-09 22:01 ` Andy Green
2015-01-18 5:11 ` [PATCH 7/7] net: wireless: wcn36xx: handle new trigger_ba format Andy Green
2015-01-27 19:58 ` Eugene Krasnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BB9D3C.90306@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=andy.green@linaro.org \
--cc=k.eugene.e@gmail.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.