Re: [net-next PATCH v2 1/1] net: sched: Introduce connmark action

[Jamal Hadi Salim <jhs@mojatatu.com>]

On 01/18/15 16:00, Cong Wang wrote:
> On Sun, Jan 18, 2015 at 12:00 PM, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>> +
>> +MODULE_AUTHOR("Felix Fietkau <nbd@openwrt.org>");
>> +MODULE_DESCRIPTION("Connection tracking mark restoring");
>> +MODULE_LICENSE("GPL");
>
>
> Please move these to the bottom.
>

Done.

>> +
>> +static int __init connmark_init_module(void)
>> +{
>> +       int ret;
>> +
>> +       ret = tcf_hashinfo_init(&connmark_hash_info, CONNMARK_TAB_MASK);
>> +       if (ret)
>> +               return ret;
>> +
>
> Is this against latest net-next? We don't need to init the hashinfo anymore,
> tcf_register_action() already does that.
>

The code itself has been living outside the tree - so i am just doing
only necessary transforms. The above was needed because the action
was maintaining its own hash.
I will convert to the new mode.

>> +       return tcf_register_action(&act_connmark_ops, CONNMARK_TAB_MASK);
>> +}
>> +
>> +static void __exit connmark_cleanup_module(void)
>> +{
>> +       tcf_unregister_action(&act_connmark_ops);
>> +}
>> +
>
> Even if we really needed, you forgot to call tcf_hashinfo_destroy()?
>

Didnt follow - why do you need tcf_hashinfo_destroy()?

Will send v3 shortly

cheers,
jamal

> Thanks.
>