From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity Date: Mon, 19 Jan 2015 11:17:47 +0800 Message-ID: <54BC775B.5020400@huawei.com> References: <1421372666-12288-1-git-send-email-wangyijing@huawei.com> <1421372666-12288-24-git-send-email-wangyijing@huawei.com> <54BA9052.9080904@cogentembedded.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54BA9052.9080904@cogentembedded.com> Sender: linux-ia64-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Sergei Shtylyov , Bjorn Helgaas Cc: Liviu Dudau , Tony Luck , Russell King , Arnd Bergmann , Marc Zyngier , linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , linux-m68k@lists.linux-m68k.org, Geert Uytterhoeven , linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, Thomas Gleixner , Guan Xuetao , Yinghai Lu , Jiang Liu , linux-arm-kernel@lists.infradead.org On 2015/1/18 0:39, Sergei Shtylyov wrote: > Hello. > > On 1/16/2015 4:44 AM, Yijing Wang wrote: > >> Use pci_scan_root_bus() instead of pci_create_root_bus() + >> pci_scan_child_bus() for simplicity. > >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/host/pcie-designware.c | 4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) > >> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c >> index eef3111..d37fe27 100644 >> --- a/drivers/pci/host/pcie-designware.c >> +++ b/drivers/pci/host/pcie-designware.c >> @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys) >> struct pcie_port *pp = sys_to_pcie(sys); >> >> pp->root_bus_nr = sys->busnr; >> - bus = pci_create_root_bus(pp->dev, sys->busnr, >> + bus = pci_scan_root_bus(pp->dev, sys->busnr, >> &dw_pcie_ops, sys, &sys->resources); > > Please realign this line, so that it still starts under 'pp'. ok. > > WBR, Sergei > > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Date: Mon, 19 Jan 2015 03:17:47 +0000 Subject: Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity Message-Id: <54BC775B.5020400@huawei.com> List-Id: References: <1421372666-12288-1-git-send-email-wangyijing@huawei.com> <1421372666-12288-24-git-send-email-wangyijing@huawei.com> <54BA9052.9080904@cogentembedded.com> In-Reply-To: <54BA9052.9080904@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Shtylyov , Bjorn Helgaas Cc: Liviu Dudau , Tony Luck , Russell King , Arnd Bergmann , Marc Zyngier , linux-pci@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , linux-m68k@vger.kernel.org, Geert Uytterhoeven , linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, Thomas Gleixner , Guan Xuetao , Yinghai Lu , Jiang Liu , linux-arm-kernel@lists.infradead.org On 2015/1/18 0:39, Sergei Shtylyov wrote: > Hello. > > On 1/16/2015 4:44 AM, Yijing Wang wrote: > >> Use pci_scan_root_bus() instead of pci_create_root_bus() + >> pci_scan_child_bus() for simplicity. > >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/host/pcie-designware.c | 4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) > >> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c >> index eef3111..d37fe27 100644 >> --- a/drivers/pci/host/pcie-designware.c >> +++ b/drivers/pci/host/pcie-designware.c >> @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys) >> struct pcie_port *pp = sys_to_pcie(sys); >> >> pp->root_bus_nr = sys->busnr; >> - bus = pci_create_root_bus(pp->dev, sys->busnr, >> + bus = pci_scan_root_bus(pp->dev, sys->busnr, >> &dw_pcie_ops, sys, &sys->resources); > > Please realign this line, so that it still starts under 'pp'. ok. > > WBR, Sergei > > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <54BC775B.5020400@huawei.com> Date: Mon, 19 Jan 2015 11:17:47 +0800 From: Yijing Wang MIME-Version: 1.0 To: Sergei Shtylyov , Bjorn Helgaas CC: Liviu Dudau , Tony Luck , "Russell King" , Arnd Bergmann , Marc Zyngier , , , , "David S. Miller" , , Geert Uytterhoeven , , , Thomas Gleixner , Guan Xuetao , Yinghai Lu , Jiang Liu , Subject: Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity References: <1421372666-12288-1-git-send-email-wangyijing@huawei.com> <1421372666-12288-24-git-send-email-wangyijing@huawei.com> <54BA9052.9080904@cogentembedded.com> In-Reply-To: <54BA9052.9080904@cogentembedded.com> Content-Type: text/plain; charset="windows-1252" Sender: linux-kernel-owner@vger.kernel.org List-ID: On 2015/1/18 0:39, Sergei Shtylyov wrote: > Hello. > > On 1/16/2015 4:44 AM, Yijing Wang wrote: > >> Use pci_scan_root_bus() instead of pci_create_root_bus() + >> pci_scan_child_bus() for simplicity. > >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/host/pcie-designware.c | 4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) > >> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c >> index eef3111..d37fe27 100644 >> --- a/drivers/pci/host/pcie-designware.c >> +++ b/drivers/pci/host/pcie-designware.c >> @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys) >> struct pcie_port *pp = sys_to_pcie(sys); >> >> pp->root_bus_nr = sys->busnr; >> - bus = pci_create_root_bus(pp->dev, sys->busnr, >> + bus = pci_scan_root_bus(pp->dev, sys->busnr, >> &dw_pcie_ops, sys, &sys->resources); > > Please realign this line, so that it still starts under 'pp'. ok. > > WBR, Sergei > > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 From: wangyijing@huawei.com (Yijing Wang) Date: Mon, 19 Jan 2015 11:17:47 +0800 Subject: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity In-Reply-To: <54BA9052.9080904@cogentembedded.com> References: <1421372666-12288-1-git-send-email-wangyijing@huawei.com> <1421372666-12288-24-git-send-email-wangyijing@huawei.com> <54BA9052.9080904@cogentembedded.com> Message-ID: <54BC775B.5020400@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2015/1/18 0:39, Sergei Shtylyov wrote: > Hello. > > On 1/16/2015 4:44 AM, Yijing Wang wrote: > >> Use pci_scan_root_bus() instead of pci_create_root_bus() + >> pci_scan_child_bus() for simplicity. > >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/host/pcie-designware.c | 4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) > >> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c >> index eef3111..d37fe27 100644 >> --- a/drivers/pci/host/pcie-designware.c >> +++ b/drivers/pci/host/pcie-designware.c >> @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys) >> struct pcie_port *pp = sys_to_pcie(sys); >> >> pp->root_bus_nr = sys->busnr; >> - bus = pci_create_root_bus(pp->dev, sys->busnr, >> + bus = pci_scan_root_bus(pp->dev, sys->busnr, >> &dw_pcie_ops, sys, &sys->resources); > > Please realign this line, so that it still starts under 'pp'. ok. > > WBR, Sergei > > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751602AbbASDSG (ORCPT ); Sun, 18 Jan 2015 22:18:06 -0500 Received: from szxga01-in.huawei.com ([119.145.14.64]:43634 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbbASDSE (ORCPT ); Sun, 18 Jan 2015 22:18:04 -0500 Message-ID: <54BC775B.5020400@huawei.com> Date: Mon, 19 Jan 2015 11:17:47 +0800 From: Yijing Wang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Sergei Shtylyov , Bjorn Helgaas CC: Liviu Dudau , Tony Luck , "Russell King" , Arnd Bergmann , Marc Zyngier , , , , "David S. Miller" , , Geert Uytterhoeven , , , Thomas Gleixner , Guan Xuetao , Yinghai Lu , Jiang Liu , Subject: Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity References: <1421372666-12288-1-git-send-email-wangyijing@huawei.com> <1421372666-12288-24-git-send-email-wangyijing@huawei.com> <54BA9052.9080904@cogentembedded.com> In-Reply-To: <54BA9052.9080904@cogentembedded.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.212] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/1/18 0:39, Sergei Shtylyov wrote: > Hello. > > On 1/16/2015 4:44 AM, Yijing Wang wrote: > >> Use pci_scan_root_bus() instead of pci_create_root_bus() + >> pci_scan_child_bus() for simplicity. > >> Signed-off-by: Yijing Wang >> --- >> drivers/pci/host/pcie-designware.c | 4 +--- >> 1 files changed, 1 insertions(+), 3 deletions(-) > >> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c >> index eef3111..d37fe27 100644 >> --- a/drivers/pci/host/pcie-designware.c >> +++ b/drivers/pci/host/pcie-designware.c >> @@ -725,13 +725,11 @@ static struct pci_bus *dw_pcie_scan_bus(int nr, struct pci_sys_data *sys) >> struct pcie_port *pp = sys_to_pcie(sys); >> >> pp->root_bus_nr = sys->busnr; >> - bus = pci_create_root_bus(pp->dev, sys->busnr, >> + bus = pci_scan_root_bus(pp->dev, sys->busnr, >> &dw_pcie_ops, sys, &sys->resources); > > Please realign this line, so that it still starts under 'pp'. ok. > > WBR, Sergei > > > . > -- Thanks! Yijing