All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: niederp@physik.uni-kl.de
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	jarkko.nikula@bitmer.com
Subject: Re: [PATCH] ASoC: OMAP: mcbsp: ensure that CLKX and CLKR are not used as ouput pins when they are used as input clock for the SRG.
Date: Mon, 19 Jan 2015 09:44:51 +0200	[thread overview]
Message-ID: <54BCB5F3.6000704@ti.com> (raw)
In-Reply-To: <1421420798.2546.22.camel@ag-ott-thomas.physik.uni-kl.de>

On 01/16/2015 05:06 PM, Thomas Niederprüm wrote:
>> Unfortunately the omap-mcbsp driver only supports synchronous configuration
>> for tx/rx (since almost all McBSP instance can only be used this way). The
>> first stream will configure both tx and rx to have the same properties. Even
>> if you are using McBSP1 which has separate FSX and FSR lines, the driver does
>> not have support for this.
>> From HW point of view this configuration is valid (not something I would
>> expect in any product). I don't think there are or will be other designs than
>> your using this mode... But, if you add some comment around the masking of
>> CLKXM and CLKRM bits that would be great.
> 
> Do you mean adding it to the commit message or to the code? or both?

Since this is something that the driver has not meant to support officially, I
prefer both. I just hope that HW designers will not get ideas based on this ;)

-- 
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

      reply	other threads:[~2015-01-19  7:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 22:28 [PATCH] ASoC: OMAP: mcbsp: ensure that CLKX and CLKR are not used as ouput pins when they are used as input clock for the SRG Thomas Niederprüm
2015-01-16  9:09 ` Jarkko Nikula
2015-01-16  9:15 ` Peter Ujfalusi
2015-01-16 10:15   ` Thomas Niederprüm
2015-01-16 12:42     ` Peter Ujfalusi
2015-01-16 15:06       ` Thomas Niederprüm
2015-01-19  7:44         ` Peter Ujfalusi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BCB5F3.6000704@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=niederp@physik.uni-kl.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.