From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] xen/many: xfree() can tolerate NULL pointers
Date: Mon, 19 Jan 2015 11:12:48 +0000
Message-ID: <54BCE6B0.6090707@citrix.com>
References: <1421664139-9058-1-git-send-email-andrew.cooper3@citrix.com>
	<1421664847.10440.41.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1421664847.10440.41.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Jan Beulich <JBeulich@suse.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 19/01/15 10:54, Ian Campbell wrote:
> On Mon, 2015-01-19 at 10:42 +0000, Andrew Cooper wrote:
>> Replace instances of "if ( p ) xfree(p)" with just "xfree(p)"
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>> CC: Keir Fraser <keir@xen.org>
>> CC: Jan Beulich <JBeulich@suse.com>
>> CC: Tim Deegan <tim@xen.org>
>> CC: Ian Campbell <Ian.Campbell@citrix.com>
>> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
>>
>> ---
>>
>> This was from some experimentation with semantic patches.  'spatch' can't
>> currently parse some of our macros (e.g. XEN_GUEST_HANDLE()), which cases it
>> to skip large numbers of functions in the codebase
> How annoying! (and surprising)

It also can't parse the "case $X ... $Y:" syntax if the spaces around
the ellipsis is missing.  This is a little more understandable as this
gccism does introduce an ambiguity into the grammar, insofar that 1...3
is not a valid floating point constant.

We have a number of uses with #defined numbers uses without spaces. 
This turns out to be safe only because the preprocessor replacement puts
spaces around replaced tokens.

>
> Anyway, could you include the spatch in the commit log, for completeness
> and for future cargo culting ;-) (unless it's huge, I guess)

It was tiny, but sadly scummed to a `git clean`.  I can't even recall
which of the many kfree() variants I ended up modifying (s/k/x/), but
there is a huge library of generic and Linux specific semantic patches
at https://github.com/coccinelle/coccinellery

~Andrew