Re: [PATCH 5/5] KVM: nVMX: Enable nested posted interrupt processing.

[Paolo Bonzini <pbonzini@redhat.com>]

Hi Wincy,

there is only one thing that I don't understand in this patchset, and it is:

On 16/01/2015 06:59, Wincy Van wrote:
> +       /*
> +        * if vcpu is in L2, we are fast enough to complete
> +        * before L1 changes/destroys vmcs12.
> +        */

... this comment.  What do you mean exactly?

Paolo

> +       local_irq_save(flags);
> +       vmcs12 = get_vmcs12(vcpu);
> +       if (!is_guest_mode(vcpu) || !vmcs12) {
> +               r = -1;
> +               goto out;
> +       }
> +       if (vector == vmcs12->posted_intr_nv &&
> +           nested_cpu_has_posted_intr(vmcs12)) {
> +               if (vcpu->mode == IN_GUEST_MODE)
> +                       apic->send_IPI_mask(get_cpu_mask(vcpu->cpu),
> +                               POSTED_INTR_VECTOR);
> +               else {
> +                       r = -1;
> +                       goto out;
> +               }
> +