From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [RFC PATCH V2 0/8] xen: Clean-up of mem_event subsystem Date: Mon, 19 Jan 2015 13:03:35 +0000 Message-ID: <54BD00A7.1000804@citrix.com> References: <1421594281-27658-1-git-send-email-tamas.lengyel@zentific.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1421594281-27658-1-git-send-email-tamas.lengyel@zentific.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xen.org Cc: kevin.tian@intel.com, wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com, eddie.dong@intel.com, andres@lagarcavilla.org, jun.nakajima@intel.com, rshriram@cs.ubc.ca, keir@xen.org, dgdegra@tycho.nsa.gov, yanghy@cn.fujitsu.com List-Id: xen-devel@lists.xenproject.org On 18/01/15 15:17, Tamas K Lengyel wrote: > This patch series aims to clean up the mem_event subsystem within Xen. The > original use-case for this system was to allow external helper applications > running in privileged domains to control various memory operations performed > by Xen. Amongs these were paging, sharing and access control. The subsystem > has since been extended to also deliver non-memory related events, namely > various HVM debugging events (INT3, MTF, MOV-TO-CR, MOV-TO-MSR). The structures > and naming of related functions however has not caught up to these new > use-cases, thus leaving many ambigouities in the code. > > In this series we convert the mem_event structures to a union of sub-structures > which clearly define the scope of information that is transmitted via the event > delivery mechanism. Afterwards, we clean up the naming of the structures and > related functions to more clearly be in line with their actual operations. > > This RFC PATCH series is also available at: > https://github.com/tklengyel/xen/tree/mem_event_cleanup2 One note to start with. There are a lot of file renames in this series. Using gits -M option for patches should make the series rather smaller. I also wonder whether it might be easier to organise the series along the lines of introducing vm_event, move the existing interfaces across, then deleting mem_event. Lets see how easy it is to review in its current form first though. ~Andrew