From: Joseph Qi <joseph.qi@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] About the commit 1b56e98990
Date: Mon, 19 Jan 2015 21:29:37 +0800 [thread overview]
Message-ID: <54BD06C1.8030009@huawei.com> (raw)
Hi Viro,
In the commit 1b56e98990 (ocfs2 syncs the wrong range...) you submitted,
you changed pos to *ppos when sync the range.
I don't think this is right, because *ppos will be changed in
generic_file_direct_write/generic_file_buffered_write, so after this
change, the sync range is not the one that we truly want.
Am I miss something?
--
Joseph
reply other threads:[~2015-01-19 13:29 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD06C1.8030009@huawei.com \
--to=joseph.qi@huawei.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.