From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Stephan Mueller <smueller@chronox.de>,
'Herbert Xu' <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org, 'LKML' <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: aesni: add setkey for driver-gcm-aes-aesni
Date: Mon, 19 Jan 2015 06:34:29 -0800 [thread overview]
Message-ID: <54BD15F5.8@intel.com> (raw)
In-Reply-To: <2587101.YvN0IxRmOH@tachyon.chronox.de>
On 01/18/2015 02:56 PM, Stephan Mueller wrote:
> The cipher registered as __driver-gcm-aes-aesni is never intended
> to be used directly by any caller. Instead it is a service mechanism to
> rfc4106-gcm-aesni.
>
> The kernel crypto API unconditionally calls the registered setkey
> function. In case a caller erroneously uses __driver-gcm-aes-aesni a
> call to crypto_aead_setkey will cause a NULL pointer dereference without
> this patch.
Acked-by: Tadeusz Struk <tadeusz.struk@intel.com>
next prev parent reply other threads:[~2015-01-19 14:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 22:56 [PATCH] crypto: aesni: add setkey for driver-gcm-aes-aesni Stephan Mueller
2015-01-18 22:58 ` Stephan Mueller
2015-01-19 14:34 ` Tadeusz Struk [this message]
2015-01-20 3:17 ` Herbert Xu
2015-01-20 3:35 ` Stephan Mueller
2015-01-20 3:37 ` Herbert Xu
2015-01-20 3:54 ` Stephan Mueller
2015-01-20 4:03 ` Herbert Xu
2015-01-21 1:25 ` Stephan Mueller
2015-01-22 18:23 ` Tadeusz Struk
2015-01-22 21:20 ` Stephan Mueller
2015-01-22 21:55 ` Tadeusz Struk
2015-01-22 22:23 ` Herbert Xu
2015-01-22 22:30 ` Tadeusz Struk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD15F5.8@intel.com \
--to=tadeusz.struk@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.