All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: Hagen Paul Pfeifer <hagen@jauu.net>
Cc: Vadim Kochan <vadim4j@gmail.com>, netdev <netdev@vger.kernel.org>,
	stephen@networkplumber.org
Subject: Re: [PATCH iproute2 3/3] ss: Unify tcp stats output
Date: Mon, 19 Jan 2015 15:48:56 +0100	[thread overview]
Message-ID: <54BD1958.6030403@redhat.com> (raw)
In-Reply-To: <CAPh34me7KFWnwgOaJmWZg3NxtzOZVce3VYShSy5PfeUkYkJcag@mail.gmail.com>

On 01/19/2015 03:28 PM, Hagen Paul Pfeifer wrote:
> Hey Vadin,
>
> to make this short. We already discussed about changing the layout and
> Stephen nacked this. My proposal was to key:value the output. Because
> nearly all outputed data is already in this format - except the
> congestion control algo, ts, sack and tx'ed data. Where I proposed
> cc:<algo>. The key:value format has the advantages that the ordering
> do not mather anymore, An python parser would be something like split
> for whitespaces and later split for colon. Currently parsing this is a
> mess, see [1].
>
> Anyway, the more clever idea is to add an json outputer like already
> supported by some ss modules and get rid of this mess.

+1

I was also thinking in addition to json, that it might be useful to have
an optional ncurses top-like mode in ss. The level of detail could be
unfolded for a specific entry on demand, etc. I would not add it as a
hard library requirement, but in case ncurses headers are detected by
the configure script, it could be compiled in then. It's also easily
changeable since there's no such requirement that the way data is being
displayed needs to be stable for scripts.

> Hagen
>
> [1] https://github.com/hgn/captcp/blob/master/captcp.py#L4861

  parent reply	other threads:[~2015-01-19 14:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-18 20:43 [PATCH iproute2 0/3] Unify output for inet sockets Vadim Kochan
2015-01-18 20:43 ` [PATCH iproute2 1/3] ss: Make meminfo look little bit more readable Vadim Kochan
2015-01-18 20:43 ` [PATCH iproute2 2/3] ss: Unify inet sockets output Vadim Kochan
2015-01-18 20:43 ` [PATCH iproute2 3/3] ss: Unify tcp stats output Vadim Kochan
2015-01-19 13:57   ` Hagen Paul Pfeifer
2015-01-19 14:04     ` Vadim Kochan
2015-01-19 14:28       ` Hagen Paul Pfeifer
2015-01-19 14:28         ` Vadim Kochan
2015-01-19 15:01           ` Hagen Paul Pfeifer
2015-01-19 14:48         ` Daniel Borkmann [this message]
2015-01-19 14:50           ` Vadim Kochan
2015-01-20 10:29   ` Hagen Paul Pfeifer
2015-01-20 10:52     ` Vadim Kochan
2015-01-20 11:06     ` Vadim Kochan
2015-01-20 11:17     ` Daniel Borkmann
2015-01-20 11:09       ` Vadim Kochan
2015-01-20 11:43       ` Hagen Paul Pfeifer
2015-01-20 18:36     ` Cong Wang
2015-01-21  8:54       ` Hagen Paul Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BD1958.6030403@redhat.com \
    --to=dborkman@redhat.com \
    --cc=hagen@jauu.net \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vadim4j@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.