From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 3/3] xen/arm: Find automatically a PPI for the DOM0 event channel interrupt Date: Mon, 19 Jan 2015 16:19:14 +0000 Message-ID: <54BD2E82.10600@linaro.org> References: <1421353422-13133-1-git-send-email-julien.grall@linaro.org> <1421353422-13133-4-git-send-email-julien.grall@linaro.org> <1421683446.10440.132.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YDF3I-0004xW-5w for xen-devel@lists.xenproject.org; Mon, 19 Jan 2015 16:19:44 +0000 Received: by mail-wi0-f173.google.com with SMTP id r20so16859506wiv.0 for ; Mon, 19 Jan 2015 08:19:42 -0800 (PST) In-Reply-To: <1421683446.10440.132.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: christoffer.dall@linaro.org, xen-devel@lists.xenproject.org, tim@xen.org, parth.dixit@linaro.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 19/01/15 16:04, Ian Campbell wrote: > On Thu, 2015-01-15 at 20:23 +0000, Julien Grall wrote: > > Subject should be "Automatically find..." > >> Use the new vgic interface to know which virtual PPI is free and use it >> for the event channel code. >> >> At the DOM0 creation time, Xen still don't know which vIRQ will be free. > > "...Xen still doesn't know..." or just "... Xen doesn't know..." I will use the second suggestion. > >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 3d4f317..d5959b5 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -627,6 +627,16 @@ static int make_hypervisor_node(struct domain *d, > > I'd prefer this not to be done in make_hypervisor_node, to keep > make_*_node purely about creating the DT, without other side effects, as > far as possible. > > I think you can drop a placeholder here and update it around the time of > the calls to kernel_load and initrd_load from a new helper function > which allocates and updates. initrd_load does something similar. I will give a look. Regards, -- Julien Grall