From: Shuah Khan <shuahkh@osg.samsung.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
m.chehab@samsung.com, hans.verkuil@cisco.com,
dheitmueller@kernellabs.com, prabhakar.csengg@gmail.com,
sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com,
ttmesterr@gmail.com
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] media: au0828 change to not zero out fmt.pix.priv
Date: Mon, 19 Jan 2015 10:07:56 -0700 [thread overview]
Message-ID: <54BD39EC.6050609@osg.samsung.com> (raw)
In-Reply-To: <54B3D319.2090506@xs4all.nl>
On 01/12/2015 06:58 AM, Hans Verkuil wrote:
> My first code review of the new year, so let's start with a simple one to avoid
> taxing my brain cells (that are still in vacation mode) too much...
>
> On 12/18/2014 05:20 PM, Shuah Khan wrote:
>> There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap()
>> vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it.
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
>
> Happy New Year!
Hans,
Thanks. Just FYI, I dropped this patch from the patch v3
series since it has been Acked. Please note that that this
version is what needs to be pulled in.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-01-19 17:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 16:20 [PATCH v2 0/3] au0828 vb2 conversion Shuah Khan
2014-12-18 16:20 ` [PATCH v2 1/3] media: au0828 - convert to use videobuf2 Shuah Khan
2015-01-12 14:19 ` Hans Verkuil
2015-01-13 2:00 ` Shuah Khan
2015-01-12 14:33 ` Hans Verkuil
2014-12-18 16:20 ` [PATCH v2 2/3] media: au0828 change to not zero out fmt.pix.priv Shuah Khan
2015-01-12 13:58 ` Hans Verkuil
2015-01-13 2:13 ` Shuah Khan
2015-01-19 17:07 ` Shuah Khan [this message]
2015-01-22 10:31 ` Lad, Prabhakar
2014-12-18 16:20 ` [PATCH v2 3/3] media: au0828 remove video and vbi buffer timeout work-around Shuah Khan
2015-01-12 14:10 ` Hans Verkuil
2015-01-13 2:08 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD39EC.6050609@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=dheitmueller@kernellabs.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=prabhakar.csengg@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=ttmesterr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.