From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49959)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YDFvO-00040r-Mr
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:15:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YDFvL-0000j0-Gv
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:15:38 -0500
Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:47459)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YDFvL-0000iu-8s
	for qemu-devel@nongnu.org; Mon, 19 Jan 2015 12:15:35 -0500
Received: by mail-wg0-f50.google.com with SMTP id b13so4447331wgh.9
	for <qemu-devel@nongnu.org>; Mon, 19 Jan 2015 09:15:34 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <54BD3BB3.1020902@redhat.com>
Date: Mon, 19 Jan 2015 18:15:31 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1421120079-987-1-git-send-email-jsnow@redhat.com>
	<1421120079-987-15-git-send-email-jsnow@redhat.com>
In-Reply-To: <1421120079-987-15-git-send-email-jsnow@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/14] libqos/ahci: create libqos/ahci.c
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, marc.mari.barcelo@gmail.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com



On 13/01/2015 04:34, John Snow wrote:
> +tests/ahci-test$(EXESUF): tests/ahci-test.o $(libqos-pc-obj-y) \
> +                          tests/libqos/ahci.o

Why not add this to libqos-pc-obj-y or libqos-obj-y?

> 
> + * Allocate space in the guest using information in the AHCIQState object.
> + */
> +uint64_t ahci_alloc(AHCIQState *ahci, size_t bytes)
> +{
> +    g_assert(ahci);
> +    g_assert(ahci->parent);
> +    return qmalloc(ahci->parent, bytes);

No need to assert if you'd get a subsequent NULL pointer access.

> +}
> +
> +void ahci_free(AHCIQState *ahci, uint64_t addr)
> +{
> +    g_assert(ahci);
> +    g_assert(ahci->parent);
> +    qfree(ahci->parent, addr);
> +}

Same here.

> +    g_assert(ahci->hba_base != 0);

Comparing void * to NULL.  Not a problem since I think hba_base should
become an uint32_t anyway.

Paolo