From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH 10/14] xen/gntdev: convert priv->lock to a
 mutex
Date: Mon, 19 Jan 2015 17:53:22 +0000
Message-ID: <54BD4492.8040204@citrix.com>
References: <1421682692-20628-1-git-send-email-david.vrabel@citrix.com>
	<1421682692-20628-11-git-send-email-david.vrabel@citrix.com>
	<alpine.DEB.2.02.1501191749080.12653@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1YDGeI-0000zI-Re
	for xen-devel@lists.xenproject.org; Mon, 19 Jan 2015 18:02:02 +0000
In-Reply-To: <alpine.DEB.2.02.1501191749080.12653@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 19/01/15 17:49, Stefano Stabellini wrote:
> On Mon, 19 Jan 2015, David Vrabel wrote:
>> Unmapping may require sleeping and we unmap while holding priv->lock, so
>> convert it to a mutex.
> 
> It would be useful to list in the commit message the operations that
> might sleep and are currently called with the spinlock held.

It's the next patch that introduces the sleeping, when we wait on the
completion for the async grant unmap to complete.

David