Re: [PATCH] libata: prevent HSM state change race between ISR and PIO

[David Milburn <dmilburn@redhat.com>]

Hi Tejun,

On 01/19/2015 11:41 AM, Tejun Heo wrote:
> On Mon, Jan 19, 2015 at 10:27:31AM -0600, David Milburn wrote:
>>   void ata_sff_flush_pio_task(struct ata_port *ap)
>>   {
>> +	struct Scsi_Host *host = ap->scsi_host;
>> +	unsigned long flags;
>> +
>>   	DPRINTK("ENTER\n");
>>
>>   	cancel_delayed_work_sync(&ap->sff_pio_task);
>> +
>> +	/* prevent racing with ISR's use of ap->hsm_task_state */
>
> Can we have a more descriptive comment please?  lock, assign, unlock
> sequence is pretty unusual, so let's give the full explanation here.
>

Ok, will do.

Thanks,
David