From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] sunxi: display: Make lcd display clk phase configurable
Date: Mon, 19 Jan 2015 20:06:30 +0100 [thread overview]
Message-ID: <54BD55B6.6090807@redhat.com> (raw)
In-Reply-To: <CAPnjgZ0mOUasCUrbXVvvmohZL03shTMYkbAnWz8ocCS8m6vzjA@mail.gmail.com>
Hi,
On 18-01-15 04:12, Simon Glass wrote:
> Hi Hans,
>
> On 13 January 2015 at 04:33, Hans de Goede <hdegoede@redhat.com> wrote:
>> While running some tests with an Olinuxino-A13-Micro + a 7" Olimex LCD module
>> I noticed that the screen flickered. This is caused by the lcd display clk
>> phase reg value being set to 0, where it should be 1 in this setup.
>>
>> This commit adds a Kconfig option for the lcd display clk phase, so that we
>> can set it per board. This defaults to 1, because looking at all the fex
>> files in sunxi-boards, that is by far the most used value.
>>
>> This commit updated the Ippo and MSI Primo73 tablet defconfigs to override the
>> default of 1 with 0, as that is the correct value for those tablets, this
>> keeps the register settings the same as before this commit.
>>
>> The Olinuxino-A13 defconfigs are not updated, changing the register setting
>> for these boards from 0 to 1, this is intentional.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> arch/arm/include/asm/arch-sunxi/display.h | 4 +---
>> board/sunxi/Kconfig | 7 +++++++
>> configs/Ippo_q8h_v1_2_defconfig | 1 +
>> configs/Ippo_q8h_v5_defconfig | 1 +
>> configs/MSI_Primo73_defconfig | 1 +
>> drivers/video/sunxi_display.c | 7 +------
>> 6 files changed, 12 insertions(+), 9 deletions(-)
>
> Are you planning to move this to device tree at some point?
Yes, one of the free-electrons guys is working on a kms driver, once we've that
and thus stable devicetree bindings for the display blocks I want to move all
this over to devicetree.
Regards,
Hans
next prev parent reply other threads:[~2015-01-19 19:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 12:33 [U-Boot] [PATCH] sunxi: display: Make lcd display clk phase configurable Hans de Goede
2015-01-17 23:05 ` Ian Campbell
2015-01-18 3:12 ` Simon Glass
2015-01-19 19:06 ` Hans de Goede [this message]
2015-01-19 19:46 ` Simon Glass
2015-01-19 20:10 ` Hans de Goede
2015-01-20 3:26 ` Simon Glass
2015-01-18 11:33 ` Siarhei Siamashka
2015-01-18 12:21 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD55B6.6090807@redhat.com \
--to=hdegoede@redhat.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.