From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ed White Subject: Re: [PATCH 00/11] Alternate p2m: support multiple copies of host p2m Date: Mon, 19 Jan 2015 11:35:32 -0800 Message-ID: <54BD5C84.7050402@intel.com> References: <1420838801-11704-1-git-send-email-edmund.h.white@intel.com> <20150115161519.GA57240@deinos.phlegethon.org> <54B805B0.8090604@intel.com> <20150116183306.GJ48064@deinos.phlegethon.org> <54B985EF.2080002@intel.com> <20150117094954.GD35432@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150117094954.GD35432@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: keir@xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, jbeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 01/17/2015 01:49 AM, Tim Deegan wrote: > At 13:43 -0800 on 16 Jan (1421412191), Ed White wrote: >> I've tried to make all my work consistent with existing code >> and design in the same vein or same source file, regardless of my >> opinion of that existing content, unless I had some compelling reason >> not to. I've also tried not to touch anything that I didn't absolutely >> have to touch (and as I've hinted, I'm not allowed to touch nested p2m). >> >> I'm sure I haven't always succeeded, but that has been my intent. >> My view was that this approach gave me the best chance of getting >> the work accepted. > > Thank you for that, by the way. I realise that this kind of review > can be terribly off-putting because every negative thing has to be > gone over in detail whereas the positives are pretty well taken for > granted. And there is basically no way to get everything right first > time through -- you'll see that even code from long-time contributors > goes through the same process. I'm not upset or discouraged. Now that you all understand at least in broad terms what I'm trying to achieve, no-one is telling me to go away and forget the whole idea. Late last week some of our discussion had become philosophical, so I thought it was worth making my philosophy clear: I want to make Xen support these capabilities, and I want to do it properly, and I want to make it as easy as possible for you to accept the changes. Righting all the wrongs I perceive in Xen can wait for another day. Ed