From: Daniel Borkmann <dborkman@redhat.com>
To: Harout Hedeshian <harouth@codeaurora.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA
Date: Mon, 19 Jan 2015 23:10:30 +0100 [thread overview]
Message-ID: <54BD80D6.40402@redhat.com> (raw)
In-Reply-To: <1421703363-3376-1-git-send-email-harouth@codeaurora.org>
On 01/19/2015 10:36 PM, Harout Hedeshian wrote:
...
> diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
> index 0956373..45e4fcf 100644
> --- a/include/uapi/linux/sysctl.h
> +++ b/include/uapi/linux/sysctl.h
> @@ -570,6 +570,7 @@ enum {
> NET_IPV6_PROXY_NDP=23,
> NET_IPV6_ACCEPT_SOURCE_ROUTE=25,
> NET_IPV6_ACCEPT_RA_FROM_LOCAL=26,
> + NET_IPV6_ACCEPT_RA_MTU=27,
> __NET_IPV6_MAX
> };
>
> diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
> index 7e7746a..16091e5 100644
> --- a/kernel/sysctl_binary.c
> +++ b/kernel/sysctl_binary.c
> @@ -523,6 +523,7 @@ static const struct bin_table bin_net_ipv6_conf_var_table[] = {
> { CTL_INT, NET_IPV6_PROXY_NDP, "proxy_ndp" },
> { CTL_INT, NET_IPV6_ACCEPT_SOURCE_ROUTE, "accept_source_route" },
> { CTL_INT, NET_IPV6_ACCEPT_RA_FROM_LOCAL, "accept_ra_from_local" },
> + { CTL_INT, NET_IPV6_ACCEPT_RA_MTU, "accept_ra_mtu" },
> {}
> };
Hm, afaik, the binary sysctl interface is deprecated and nothing
should be adding entries there anymore. I believe you copied this
over from commit d9333196572 ("ipv6: Allow accepting RA from local
IP addresses.")? :/
next prev parent reply other threads:[~2015-01-19 22:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 21:36 [PATCH v2 net-next] net: ipv6: Add sysctl entry to disable MTU updates from RA Harout Hedeshian
2015-01-19 22:10 ` Daniel Borkmann [this message]
2015-01-19 22:42 ` Harout Hedeshian
2015-01-19 23:01 ` Daniel Borkmann
2015-01-20 0:29 ` David Miller
2015-01-19 23:01 ` Daniel Borkmann
2015-01-20 16:48 ` Harout Hedeshian
2015-01-20 16:56 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BD80D6.40402@redhat.com \
--to=dborkman@redhat.com \
--cc=harouth@codeaurora.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.