Re: [PATCH] ARM: atmel: sama5d3xek: let gmac auto detect phy id

From: Bo Shen <voice.shen@atmel.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM: atmel: sama5d3xek: let gmac auto detect phy id
Date: Tue, 20 Jan 2015 08:56:36 +0800	[thread overview]
Message-ID: <54BDA7C4.5030906@atmel.com> (raw)
In-Reply-To: <20150119113939.GD30554@ns203013.ovh.net>

Hi J,

On 01/19/2015 07:39 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:54 Mon 19 Jan     , Bo Shen wrote:
>> On the SAMA5D33 and SAMA5D35 the GMAC PHY ID is 1 while not 7.
>> So, let the GMAC auto detect phy id, or else hard code to 7,
>> it can not work on these two boards.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>>
>>   arch/arm/boards/sama5d3xek/init.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boards/sama5d3xek/init.c b/arch/arm/boards/sama5d3xek/init.c
>> index 49d2b37..0b83147 100644
>> --- a/arch/arm/boards/sama5d3xek/init.c
>> +++ b/arch/arm/boards/sama5d3xek/init.c
>> @@ -123,7 +123,7 @@ static void ek_add_device_nand(void) {}
>>   #if defined(CONFIG_DRIVER_NET_MACB)
>>   static struct macb_platform_data gmac_pdata = {
>>   	.phy_interface = PHY_INTERFACE_MODE_RGMII,
>> -	.phy_addr = 7,
>> +	.phy_addr = -1,
> IIRC the auto detect do not work on all board

On which board? Can you be more detail?
Thanks.

> NACK
>
> Best Regards,
> J.
>>   };
>>
>>   static struct macb_platform_data macb_pdata = {
>> --
>> 2.3.0.rc0
>>

Best Regards,
Bo Shen

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox