From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Subject: Re: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments Date: Tue, 20 Jan 2015 09:00:16 +0800 Message-ID: <54BDA8A0.1050604@atmel.com> References: <54BD0CA5.4070207@lysator.liu.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54BD0CA5.4070207@lysator.liu.se> Sender: linux-sound-owner@vger.kernel.org To: Peter Rosin Cc: Mark Brown , nicolas.ferre@atmel.com, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org Hi Peter, On 01/19/2015 09:54 PM, Peter Rosin wrote: >> As the clock can be get from TK/RK pin, so remove the comments. >> >> Signed-off-by: Bo Shen >> --- >> sound/soc/atmel/atmel_ssc_dai.c | 4 ---- >> 1 file changed, 4 deletions(-) >> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c >> index e691aab..198661b 100644 >> --- a/sound/soc/atmel/atmel_ssc_dai.c >> +++ b/sound/soc/atmel/atmel_ssc_dai.c >> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, >> case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM: >> /* >> * I2S format, CODEC supplies BCLK and LRC clocks. >> - * >> - * The SSC transmit clock is obtained from the BCLK signal on >> - * on the TK line, and the SSC receive clock is >> - * generated from the transmit clock. >> */ >> rcmr = SSC_BF(RCMR_PERIOD, 0) >> | SSC_BF(RCMR_STTDLY, START_DELAY) >> -- >> 2.3.0.rc0 > > Hi! > > You should probably remove that comment from the case with > SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well... Thanks, I will remove it in next version. > Cheers, > Peter > Best Regards, Bo Shen From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Tue, 20 Jan 2015 01:00:16 +0000 Subject: Re: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments Message-Id: <54BDA8A0.1050604@atmel.com> List-Id: References: <54BD0CA5.4070207@lysator.liu.se> In-Reply-To: <54BD0CA5.4070207@lysator.liu.se> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Rosin Cc: Mark Brown , nicolas.ferre@atmel.com, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Hi Peter, On 01/19/2015 09:54 PM, Peter Rosin wrote: >> As the clock can be get from TK/RK pin, so remove the comments. >> >> Signed-off-by: Bo Shen >> --- >> sound/soc/atmel/atmel_ssc_dai.c | 4 ---- >> 1 file changed, 4 deletions(-) >> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c >> index e691aab..198661b 100644 >> --- a/sound/soc/atmel/atmel_ssc_dai.c >> +++ b/sound/soc/atmel/atmel_ssc_dai.c >> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, >> case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM: >> /* >> * I2S format, CODEC supplies BCLK and LRC clocks. >> - * >> - * The SSC transmit clock is obtained from the BCLK signal on >> - * on the TK line, and the SSC receive clock is >> - * generated from the transmit clock. >> */ >> rcmr = SSC_BF(RCMR_PERIOD, 0) >> | SSC_BF(RCMR_STTDLY, START_DELAY) >> -- >> 2.3.0.rc0 > > Hi! > > You should probably remove that comment from the case with > SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well... Thanks, I will remove it in next version. > Cheers, > Peter > Best Regards, Bo Shen From mboxrd@z Thu Jan 1 00:00:00 1970 From: voice.shen@atmel.com (Bo Shen) Date: Tue, 20 Jan 2015 09:00:16 +0800 Subject: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments In-Reply-To: <54BD0CA5.4070207@lysator.liu.se> References: <54BD0CA5.4070207@lysator.liu.se> Message-ID: <54BDA8A0.1050604@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Peter, On 01/19/2015 09:54 PM, Peter Rosin wrote: >> As the clock can be get from TK/RK pin, so remove the comments. >> >> Signed-off-by: Bo Shen >> --- >> sound/soc/atmel/atmel_ssc_dai.c | 4 ---- >> 1 file changed, 4 deletions(-) >> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c >> index e691aab..198661b 100644 >> --- a/sound/soc/atmel/atmel_ssc_dai.c >> +++ b/sound/soc/atmel/atmel_ssc_dai.c >> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, >> case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM: >> /* >> * I2S format, CODEC supplies BCLK and LRC clocks. >> - * >> - * The SSC transmit clock is obtained from the BCLK signal on >> - * on the TK line, and the SSC receive clock is >> - * generated from the transmit clock. >> */ >> rcmr = SSC_BF(RCMR_PERIOD, 0) >> | SSC_BF(RCMR_STTDLY, START_DELAY) >> -- >> 2.3.0.rc0 > > Hi! > > You should probably remove that comment from the case with > SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well... Thanks, I will remove it in next version. > Cheers, > Peter > Best Regards, Bo Shen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752219AbbATBBC (ORCPT ); Mon, 19 Jan 2015 20:01:02 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:34787 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751505AbbATBBA (ORCPT ); Mon, 19 Jan 2015 20:01:00 -0500 Message-ID: <54BDA8A0.1050604@atmel.com> Date: Tue, 20 Jan 2015 09:00:16 +0800 From: Bo Shen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Peter Rosin CC: Mark Brown , , , , , Subject: Re: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments References: <54BD0CA5.4070207@lysator.liu.se> In-Reply-To: <54BD0CA5.4070207@lysator.liu.se> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.168.5.13] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 01/19/2015 09:54 PM, Peter Rosin wrote: >> As the clock can be get from TK/RK pin, so remove the comments. >> >> Signed-off-by: Bo Shen >> --- >> sound/soc/atmel/atmel_ssc_dai.c | 4 ---- >> 1 file changed, 4 deletions(-) >> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c >> index e691aab..198661b 100644 >> --- a/sound/soc/atmel/atmel_ssc_dai.c >> +++ b/sound/soc/atmel/atmel_ssc_dai.c >> @@ -452,10 +452,6 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream, >> case SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM: >> /* >> * I2S format, CODEC supplies BCLK and LRC clocks. >> - * >> - * The SSC transmit clock is obtained from the BCLK signal on >> - * on the TK line, and the SSC receive clock is >> - * generated from the transmit clock. >> */ >> rcmr = SSC_BF(RCMR_PERIOD, 0) >> | SSC_BF(RCMR_STTDLY, START_DELAY) >> -- >> 2.3.0.rc0 > > Hi! > > You should probably remove that comment from the case with > SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_CBM_CFM as well... Thanks, I will remove it in next version. > Cheers, > Peter > Best Regards, Bo Shen