From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re:
 =?utf-8?q?=5BPATCH_2/3=5D_x86=3A_correctly_check_for_?=
 =?utf-8?q?sub=E2=80=91leaf_zero_of_leaf_7_in_pv=5Fcpuid=28=29?=
Date: Tue, 20 Jan 2015 10:46:19 +0000
Message-ID: <54BE31FB.1050901@citrix.com>
References: <54BD2F2B0200007800056859@mail.emea.novell.com>
	<54BD307B0200007800056871@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1YDWKe-0002ud-W6
	for xen-devel@lists.xenproject.org; Tue, 20 Jan 2015 10:46:49 +0000
In-Reply-To: <54BD307B0200007800056871@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 19/01/15 15:27, Jan Beulich wrote:
> Only the low 32 bits are relevant.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

There are two examples of "regs->eax" which could turn to regs->_eax
under the same argument; the if statement immediately after cpuid, and
the switch statement.

Either way,

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -916,7 +916,7 @@ void pv_cpuid(struct cpu_user_regs *regs
>          break;
>  
>      case 0x00000007:
> -        if ( regs->ecx == 0 )
> +        if ( regs->_ecx == 0 )
>              b &= (cpufeat_mask(X86_FEATURE_BMI1) |
>                    cpufeat_mask(X86_FEATURE_HLE)  |
>                    cpufeat_mask(X86_FEATURE_AVX2) |
>
>
>