From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 3/3] x86: don't open-code cpuid_count() in
	pv_cpuid()
Date: Tue, 20 Jan 2015 10:46:47 +0000
Message-ID: <54BE3217.7010903@citrix.com>
References: <54BD2F2B0200007800056859@mail.emea.novell.com>
	<54BD30A60200007800056875@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1YDWKh-0002vK-K3
	for xen-devel@lists.xenproject.org; Tue, 20 Jan 2015 10:46:51 +0000
In-Reply-To: <54BD30A60200007800056875@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Keir Fraser <keir@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 19/01/15 15:28, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -861,10 +861,7 @@ void pv_cpuid(struct cpu_user_regs *regs
>          goto out;
>      }
>  
> -    asm ( 
> -        "cpuid"
> -        : "=a" (a), "=b" (b), "=c" (c), "=d" (d)
> -        : "0" (a), "1" (b), "2" (c), "3" (d) );
> +    cpuid_count(a, c, &a, &b, &c, &d);
>  
>      if ( (regs->eax & 0x7fffffff) == 0x00000001 )
>      {
>
>
>