From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2 1/3] xen/arm: vgic: Rename nr_lines into nr_spis Date: Tue, 20 Jan 2015 13:41:04 +0000 Message-ID: <54BE5AF0.6020307@linaro.org> References: <1421353422-13133-1-git-send-email-julien.grall@linaro.org> <1421353422-13133-2-git-send-email-julien.grall@linaro.org> <1421686850.10440.164.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YDZ3m-0006tD-Cb for xen-devel@lists.xenproject.org; Tue, 20 Jan 2015 13:41:34 +0000 Received: by mail-wi0-f174.google.com with SMTP id n3so3119287wiv.1 for ; Tue, 20 Jan 2015 05:41:32 -0800 (PST) In-Reply-To: <1421686850.10440.164.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: christoffer.dall@linaro.org, xen-devel@lists.xenproject.org, tim@xen.org, parth.dixit@linaro.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 19/01/15 17:00, Ian Campbell wrote: > On Thu, 2015-01-15 at 20:23 +0000, Julien Grall wrote: >> The field nr_lines in the arch_domain vgic structure contains the number of >> SPIs for the emulated GIC. Using the nr_lines make confusion with the GIC >> code, where it means the number of IRQs. This can lead to coding error. >> >> Also introduce vgic_num_irqs to get the number of IRQ handled by the emulated >> GIC. >> >> Finally drop the initialization of nr_spis in both gicv2v_init and gicv3_init >> as it's already initialized in vgic common code. >> >> Signed-off-by: Julien Grall >> Acked-by: Stefano Stabellini > > Acked + applied. > > Thanks, I will rebase my series "[PATCH 00/10] xen/arm: Bug fixes for the vGIC" [1] on top of it. Though I could wait a bit for your review on it. Regards, -- Julien Grall