Re: [PATCH 3.19-rc3] c_can: end transmission on network stop

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On 01/18/2015 08:01 PM, Viktor Babrian wrote:
> 
> Controller put into init mode in betwork stop to end pending 
> transmission. The issue is observed in cases when transmitted frame is not 
> acked.
> 
> Signed-off-by: Viktor Babrian <babrian.viktor@renyi.mta.hu>
> ---
> --- linux-3.19-rc3/drivers/net/can/c_can/c_can.c	2015-01-06 
> 02:05:20.000000000 +0100
> +++ linux/drivers/net/can/c_can/c_can.c	2015-01-18 18:07:09.000000000 
> +0100
> @@ -615,6 +615,9 @@ static void c_can_stop(struct net_device
> 
>   	c_can_irq_control(priv, false);
> 
> +	/* put ctrl to init on stop to end ongoing transmission */
> +	priv->write_reg(priv, C_CAN_CTRL_REG, CONTROL_INIT);
> +
>   	/* deactivate pins */
>   	pinctrl_pm_select_sleep_state(dev->dev.parent);
>   	priv->can.state = CAN_STATE_STOPPED;

Your mailer has word-wrapped the patch. I've applied it by hand to
can/master. Please consider using git send-email in the future.

Thanks,
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]