From mboxrd@z Thu Jan  1 00:00:00 1970
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2 4/4] libxl: Add interface for querying
 hypervisor about PCI topology
Date: Tue, 20 Jan 2015 10:15:47 -0500
Message-ID: <54BE7123.2050808@oracle.com>
References: <1420510737-22813-1-git-send-email-boris.ostrovsky@oracle.com>	
	<1420510737-22813-5-git-send-email-boris.ostrovsky@oracle.com>
	<1421688759.10440.176.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1421688759.10440.176.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: keir@xen.org, ufimtseva@gmail.com, stefano.stabellini@eu.citrix.com, andrew.cooper3@citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, chegger@amazon.com, jbeulich@suse.com, wei.liu2@citrix.com, Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 01/19/2015 12:32 PM, Ian Campbell wrote:
>
>> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
>> index 0a123f1..eb83f0a 100644
>> --- a/tools/libxl/libxl.h
>> +++ b/tools/libxl/libxl.h
>> @@ -1070,6 +1070,10 @@ void libxl_vminfo_list_free(libxl_vminfo *list, int nb_vm);
>>   libxl_cputopology *libxl_get_cpu_topology(libxl_ctx *ctx, int *nb_cpu_out);
>>   void libxl_cputopology_list_free(libxl_cputopology *, int nb_cpu);
>>   
>> +#define LIBXL_PCITOPOLOGY_INVALID_ENTRY (~(uint32_t)0)
>> +libxl_pcitopology *libxl_get_pci_topology(libxl_ctx *ctx, int *num_dev);
>> +void libxl_pcitopology_list_free(libxl_pcitopology *, int num_dev);
> Needs a #define LIBXL_HAVE_FOO #define to advertise the new
> functionality.

Ah, yes, Wei pointed it out to me earlier and I missed it.

>
>> diff --git a/tools/libxl/libxl_linux.c b/tools/libxl/libxl_linux.c
>> index ea5d8c1..07428c0 100644
>> --- a/tools/libxl/libxl_linux.c
>> +++ b/tools/libxl/libxl_linux.c
>> @@ -279,3 +279,74 @@ libxl_device_model_version libxl__default_device_model(libxl__gc *gc)
>>   {
>>       return LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
>>   }
>> +
>> +/* These two routines are "inspired" by pciutils */
> "inspired" in a licensing consistent way?

pciutils is licensed under GPL2 (e.g. 
http://git.kernel.org/cgit/utils/pciutils/pciutils.git/tree/COPYING) so 
this would be consistent.

Thanks.
-boris