Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1088 bytes --]

On 01/20/2015 07:29 AM, Programmingkid wrote:
> 
> On Jan 20, 2015, at 3:33 AM, Markus Armbruster wrote:
> 
>> Programmingkid <programmingkidx@gmail.com> writes:
>>
>>> Subject was: 
>>> Re: [PATCH v7] block/raw-posix.c: Fixes raw_getlength() 
>>> on Mac OS X so that it reports the correct length of a real CD
>>
>> Patch history information goes...

>>
>> ... below the --- divider.
> 
> I thought I did this. The information above is the description of the patch. 
> Not its history.

Anything that mentions 'v7' is history.  When you read 'git log', you
will not see mentions of 'v7', because no one cares how many tries it
took to get a patch into git.  Knowing about v7 only matters to the
reviewers of v8, hence it is patch history that belongs after the divider.


>>> +
>>> +            if (ioctl(fd, DKIOCGETBLOCKCOUNT, &sectors) == 0
>>> +               && ioctl(fd, DKIOCGETBLOCKSIZE, &sector_size) == 0) {

Indentation looks off here.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]