From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 2/3] xen/pvh: check permissions when adding MMIO regions Date: Tue, 20 Jan 2015 18:19:33 +0000 Message-ID: <54BE9C35.7010800@citrix.com> References: <1421773534-15752-1-git-send-email-roger.pau@citrix.com> <1421773534-15752-3-git-send-email-roger.pau@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YDdx0-000658-Dv for xen-devel@lists.xenproject.org; Tue, 20 Jan 2015 18:54:54 +0000 In-Reply-To: <1421773534-15752-3-git-send-email-roger.pau@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Roger Pau Monne , xen-devel@lists.xenproject.org Cc: Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMjAvMDEvMTUgMTc6MDUsIFJvZ2VyIFBhdSBNb25uZSB3cm90ZToKPiBDaGVjayB0aGF0IE1N SU8gcmVnaW9ucyBhZGRlZCB0byBQVkggRG9tMCBhcmUgYWxsb3dlZC4gUHJldmlvdXNseSBhIFBW SCBEb20wCj4gd291bGQgaGF2ZSBhY2Nlc3MgdG8gdGhlIGZ1bGwgTU1JTyByYW5nZS4KPgo+IFNp Z25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgo+IENj OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+Cj4gQ2M6IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBzaW5jZSB2MToKPiAgLSBV c2UgdGhlIG5ld2x5IGludHJvZHVjZWQgcDJtX2FjY2Vzc190IHRvIHNldCB0aGUgYWNjZXNzIHR5 cGUuCj4gIC0gRG9uJ3QgYWRkIGEgbmV4dCBsYWJlbC4KPiAtLS0KPiAgeGVuL2FyY2gveDg2L2Rv bWFpbl9idWlsZC5jIHwgMTcgKysrKysrKysrKysrKysrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE1 IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv eDg2L2RvbWFpbl9idWlsZC5jIGIveGVuL2FyY2gveDg2L2RvbWFpbl9idWlsZC5jCj4gaW5kZXgg ZjY4N2M3OC4uNDFkMjU0MSAxMDA2NDQKPiAtLS0gYS94ZW4vYXJjaC94ODYvZG9tYWluX2J1aWxk LmMKPiArKysgYi94ZW4vYXJjaC94ODYvZG9tYWluX2J1aWxkLmMKPiBAQCAtMzE5LDEyICszMTks MjUgQEAgc3RhdGljIF9faW5pdCB2b2lkIHB2aF9hZGRfbWVtX21hcHBpbmcoc3RydWN0IGRvbWFp biAqZCwgdW5zaWduZWQgbG9uZyBnZm4sCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbWZuLCB1bnNpZ25lZCBsb25nIG5yX21mbnMpCj4gIHsK PiAgICAgIHVuc2lnbmVkIGxvbmcgaTsKPiArICAgIG1mbl90IG9tZm47Cj4gKyAgICBwMm1fdHlw ZV90IHQ7Cj4gKyAgICBwMm1fYWNjZXNzX3QgYTsKPiAgICAgIGludCByYzsKPiAgCj4gICAgICBm b3IgKCBpID0gMDsgaSA8IG5yX21mbnM7IGkrKyApCj4gICAgICB7Cj4gLSAgICAgICAgaWYgKCAo cmMgPSBzZXRfbW1pb19wMm1fZW50cnkoZCwgZ2ZuICsgaSwgX21mbihtZm4gKyBpKSwKPiAtICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwMm1fZ2V0X2hvc3RwMm0oZCktPmRl ZmF1bHRfYWNjZXNzKSkgKQo+ICsgICAgICAgIGlmICggIWlvbWVtX2FjY2Vzc19wZXJtaXR0ZWQo ZCwgbWZuICsgaSwgbWZuICsgaSkgKSB7Cj4gKyAgICAgICAgICAgIG9tZm4gPSBnZXRfZ2ZuX3F1 ZXJ5X3VubG9ja2VkKGQsIGdmbiArIGksICZ0KTsKPiArICAgICAgICAgICAgZ3Vlc3RfcGh5c21h cF9yZW1vdmVfcGFnZShkLCBnZm4gKyBpLCBtZm5feChvbWZuKSwgUEFHRV9PUkRFUl80Syk7Cj4g KyAgICAgICAgICAgIGNvbnRpbnVlOwo+ICsgICAgICAgIH0KClRoaXMgc3VnZ2VzdHMgYSBkZXNp Z24gZmxhdyAocG9zc2libHkgcHJlLWV4aXN0aW5nKS4gIFdlIHNob3VsZCBub3QgYmUKcmVtb3Zp bmcgcGh5c21hcCBlbnRyaWVzIGluIHB2aF9hZGRfbWVtX21hcHBpbmcoKSwgbm9yIHNob3VsZCB3 ZSBiZSBhCnBvc2l0aW9uIHRvIG5lZWQgdG8gcmV2b2tlIHBoeXNtYXAgZW50cmllcyBkdXJpbmcg ZG9tYWluIGJ1aWxkLgoKSWYgdGhlcmUgaXMgYW55dGhpbmcgbmVlZGluZyByZXZva2luZyBhdCB0 aGlzIHN0YWdlLCBpdCBzaG91bGQgbm90IGhhdmUKYmVlbiBhZGRlZCBlYXJsaWVyLiAgSG93IGRp ZCB5b3UgY29tZSB0byBpbnRyb2R1Y2UgdGhpcyBjb2RlPwoKfkFuZHJldwoKPiArCj4gKyAgICAg ICAgaWYgKCByYW5nZXNldF9jb250YWluc19zaW5nbGV0b24obW1pb19yb19yYW5nZXMsIG1mbiAr IGkpICkKPiArICAgICAgICAgICAgYSA9IHAybV9hY2Nlc3NfcjsKPiArICAgICAgICBlbHNlCj4g KyAgICAgICAgICAgIGEgPSBwMm1fYWNjZXNzX3J3Owo+ICsKPiArICAgICAgICBpZiAoIChyYyA9 IHNldF9tbWlvX3AybV9lbnRyeShkLCBnZm4gKyBpLCBfbWZuKG1mbiArIGkpLCBhKSkgKQo+ICAg ICAgICAgICAgICBwYW5pYygicHZoX2FkZF9tZW1fbWFwcGluZzogZ2ZuOiVseCBtZm46JWx4IGk6 JWxkIHJjOiVkXG4iLAo+ICAgICAgICAgICAgICAgICAgICBnZm4sIG1mbiwgaSwgcmMpOwo+ICAg ICAgICAgIGlmICggIShpICYgMHhmZmZmZikgKQoKCgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBs aXN0cy54ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=