From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Thomas Graf <tgraf@suug.ch>,
davem@davemloft.net, Ying Xue <ying.xue@windriver.com>
Cc: "richard.alpe@ericsson.com >> Richard Alpe"
<richard.alpe@ericsson.com>, Netdev <netdev@vger.kernel.org>,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next] rhashtable: rhashtable_remove() must unlink in both tbl and future_tbl
Date: Tue, 20 Jan 2015 21:44:09 +0300 [thread overview]
Message-ID: <54BEA1F9.1050908@cogentembedded.com> (raw)
In-Reply-To: <20150120165826.GK20315@casper.infradead.org>
Hello.
On 01/20/2015 07:58 PM, Thomas Graf wrote:
> As removals can occur during resizes, entries may be referred to from
> both tbl and future_tbl when the removal is requested. Therefore
> rhashtable_remove() must unlink the entry in both tables if this is
> the case. The existing code did search both tables but stopped when it
> hit the first match.
> Failing to do so resulted in use after remove.
Er, failing to do what? Stopping when it hit the first match?
> Fixes: 97defe1 ("rhashtable: Per bucket locks & deferred expansion/shrinking")
SHA1 should be 12 hex digits in this case, accordong to
Documentation/SubmittingPatches.
> Reported-by: Ying Xue <ying.xue@windriver.com>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-01-20 18:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 8:03 [3.19.0-rc4+] rhashtable: BUG kmalloc-2048 (Not tainted): Poison overwritten Ying Xue
2015-01-19 12:59 ` Thomas Graf
2015-01-20 2:53 ` Ying Xue
2015-01-20 16:58 ` [PATCH net-next] rhashtable: rhashtable_remove() must unlink in both tbl and future_tbl Thomas Graf
2015-01-20 18:44 ` Sergei Shtylyov [this message]
2015-01-21 11:54 ` [PATCH net-next v2] " Thomas Graf
2015-01-26 19:57 ` David Miller
2015-01-21 8:39 ` [PATCH net-next] " Ying Xue
2015-01-21 11:56 ` Thomas Graf
2015-01-30 8:37 ` Ying Xue
2015-01-21 8:51 ` Ying Xue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BEA1F9.1050908@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=richard.alpe@ericsson.com \
--cc=tgraf@suug.ch \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.