All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Ming Lei <ming.lei@canonical.com>, <linux-kernel@vger.kernel.org>
Cc: Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [PATCH] blk-mq: fix hctx/ctx kobject use-after-free
Date: Tue, 20 Jan 2015 12:30:18 -0700	[thread overview]
Message-ID: <54BEACCA.4080800@fb.com> (raw)
In-Reply-To: <1421722856-6346-1-git-send-email-ming.lei@canonical.com>

On 01/19/2015 08:00 PM, Ming Lei wrote:
> The kobject memory shouldn't have been freed before the kobject
> is released because driver core can access it freely before its
> release.
>
> This patch frees hctx in its release callback. For ctx, they
> share one single per-cpu variable which is associated with
> the request queue, so free ctx in q->mq_kobj's release handler.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> (fix ctx kobjects)
> Signed-off-by: Ming Lei <ming.lei@canonical.com>

Thanks Ming, applied.

-- 
Jens Axboe


      reply	other threads:[~2015-01-20 19:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20  3:00 [PATCH] blk-mq: fix hctx/ctx kobject use-after-free Ming Lei
2015-01-20 19:30 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BEACCA.4080800@fb.com \
    --to=axboe@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.