All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Asaf Vertz <asaf.vertz@tandemg.com>, gregkh@linuxfoundation.org
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	mwelling@ieee.org, daniel.baluta@intel.com, aybuke.147@gmail.com,
	monamagarwal123@gmail.com, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: iio: tsl2583: fix format string warnings
Date: Tue, 20 Jan 2015 20:43:29 +0000	[thread overview]
Message-ID: <54BEBDF1.8090909@kernel.org> (raw)
In-Reply-To: <20150120104338.GA17675@ubuntu>

On 20/01/15 10:43, Asaf Vertz wrote:
> Fixed the following warnings (reported by cppcheck):
> [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 1)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 2)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 3)
> requires 'int' but the argument type is 'unsigned int'.
> 
> Signed-off-by: Asaf Vertz <asaf.vertz@tandemg.com>
Applied to the togreg branch of iio.git - initially pushed out
as testing.  Note this branch will almost certainly get rebased
before going upstream.

Jonathan
> ---
>  drivers/staging/iio/light/tsl2583.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index cc4ddcc..8afae8e 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -692,7 +692,7 @@ static ssize_t taos_luxtable_show(struct device *dev,
>  	int offset = 0;
>  
>  	for (i = 0; i < ARRAY_SIZE(taos_device_lux); i++) {
> -		offset += sprintf(buf + offset, "%d,%d,%d,",
> +		offset += sprintf(buf + offset, "%u,%u,%u,",
>  				  taos_device_lux[i].ratio,
>  				  taos_device_lux[i].ch0,
>  				  taos_device_lux[i].ch1);
> 


      reply	other threads:[~2015-01-20 20:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 10:43 [PATCH] staging: iio: tsl2583: fix format string warnings Asaf Vertz
2015-01-20 20:43 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BEBDF1.8090909@kernel.org \
    --to=jic23@kernel.org \
    --cc=asaf.vertz@tandemg.com \
    --cc=aybuke.147@gmail.com \
    --cc=daniel.baluta@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=monamagarwal123@gmail.com \
    --cc=mwelling@ieee.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.