All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Durgin <josh.durgin@inktank.com>
To: Ilya Dryomov <idryomov@redhat.com>, ceph-devel@vger.kernel.org
Cc: Alex Elder <elder@linaro.org>
Subject: Re: [PATCH 3/3] rbd: do not treat standalone as flatten
Date: Tue, 20 Jan 2015 17:25:56 -0800	[thread overview]
Message-ID: <54BF0024.2040006@inktank.com> (raw)
In-Reply-To: <1421757669-38796-4-git-send-email-idryomov@redhat.com>

On 01/20/2015 04:41 AM, Ilya Dryomov wrote:
> If the clone is resized down to 0, it becomes standalone.  If such
> resize is carried over while an image is mapped we would detect this
> and call rbd_dev_parent_put() which means "let go of all parent state,
> including the spec(s) of parent images(s)".  This leads to a mismatch
> between "rbd info" and sysfs parent fields, so a fix is in order.
>
>      # rbd create --image-format 2 --size 1 foo
>      # rbd snap create foo@snap
>      # rbd snap protect foo@snap
>      # rbd clone foo@snap bar
>      # DEV=$(rbd map bar)
>      # rbd resize --allow-shrink --size 0 bar
>      # rbd resize --size 1 bar
>      # rbd info bar | grep parent
>              parent: rbd/foo@snap
>
> Before:
>
>      # cat /sys/bus/rbd/devices/0/parent
>      (no parent image)
>
> After:
>
>      # cat /sys/bus/rbd/devices/0/parent
>      pool_id 0
>      pool_name rbd
>      image_id 10056b8b4567
>      image_name foo
>      snap_id 2
>      snap_name snap
>      overlap 0
>
> Signed-off-by: Ilya Dryomov <idryomov@redhat.com>

Reviewed-by: Josh Durgin <jdurgin@redhat.com>


  reply	other threads:[~2015-01-21  1:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 12:41 [PATCH 0/3] rbd: parent_overlap == 0 fixes Ilya Dryomov
2015-01-20 12:41 ` [PATCH 1/3] rbd: fix rbd_dev_parent_get() when parent_overlap == 0 Ilya Dryomov
2015-01-21  1:22   ` Josh Durgin
2015-01-27  3:14   ` Alex Elder
2015-01-20 12:41 ` [PATCH 2/3] rbd: drop parent_ref in rbd_dev_unprobe() unconditionally Ilya Dryomov
2015-01-21  1:24   ` Josh Durgin
2015-01-27  3:40   ` Alex Elder
2015-01-20 12:41 ` [PATCH 3/3] rbd: do not treat standalone as flatten Ilya Dryomov
2015-01-21  1:25   ` Josh Durgin [this message]
2015-01-27  3:55   ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BF0024.2040006@inktank.com \
    --to=josh.durgin@inktank.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=elder@linaro.org \
    --cc=idryomov@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.