From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 27E42E008CD; Tue, 20 Jan 2015 18:30:42 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no * trust * [193.201.172.117 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (picmaster[at]mail.bg) * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's * domain * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mx1.mail.bg (mx1.mail.bg [193.201.172.117]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 1FC41E0086E for ; Tue, 20 Jan 2015 18:30:33 -0800 (PST) Received: from [192.168.0.40] (unknown [93.152.132.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.mail.bg (Postfix) with ESMTPSA id BD3F360009D7; Wed, 21 Jan 2015 04:30:31 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mail.bg; s=default; t=1421807431; bh=oJt3PaixY3P2SMeyK0ZJ0mfaFwSEgb9WeId3p1G7/Lc=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=gKak2T0TPgGbVHpQoQZkol9xQqJZ0wrXNZVfYauUA6li/ooIsm1R6p/81DD3iuhtt 4CCEEoCAKqwobVJL9PRUJJGcnIVdX+pd+48Y04VVnmByQtT0Rerba69M+9316Yw51O UA6YPeKT8q02O4mu9dmEmCuFD2x4Pjx8hnDthPPg= Message-ID: <54BF0F40.6030407@mail.bg> Date: Wed, 21 Jan 2015 04:30:24 +0200 From: Nikolay Dimitrov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Fabio Estevam References: <54BED2E8.70901@mail.bg> <54BEF411.9080503@mail.bg> In-Reply-To: Cc: "meta-freescale@yoctoproject.org" Subject: Re: Audio glitch with SGTL5000 X-BeenThere: meta-freescale@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Usage and development list for the meta-fsl-* layers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 02:30:42 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Fabio, On 01/21/2015 02:50 AM, Fabio Estevam wrote: > Hi Nikolay, > > On Tue, Jan 20, 2015 at 10:34 PM, Nikolay Dimitrov wrote: > >> I tried to reproduce the issue also with the integrated headphone amp, >> just to find out that my board design has an issue (oops!) - the >> headphones' ground is connected to the power supply ground instead of >> the virtual ground, so I can't test the VAG ramp fix this way. So I can >> only speculate that you tested your fix on a properly wired headphone >> output, and that's where it worked OK. > > I tested on headphone output on a mx28evk. > > Here is a better link to the patch: > https://git.kernel.org/cgit/linux/kernel/git/broonie/sound.git/patch/sound/soc/codecs/sgtl5000.c?id=c251ea7bd7a04f1f2575467e0de76e803cf59149 > > The previous one only showed the change to sgtl5000.c. Thanks. But now I don't understand the logic of this patch. Here's the prototype of the helper function: int snd_soc_update_bits(struct snd_soc_codec *codec, unsigned int reg, unsigned int mask, unsigned int value); 3rd argument is a mask, and you're passing there SGTL5000_SMALL_POP, which is now 0. > Does the problem also happens on 3.19-rc5? Can't use mainline for this specific project, as I need VPU support. Kind regards, Nikolay