From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755210AbbAUCsj (ORCPT ); Tue, 20 Jan 2015 21:48:39 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:38388 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752718AbbAUCsg (ORCPT ); Tue, 20 Jan 2015 21:48:36 -0500 Message-ID: <54BF1363.2080204@roeck-us.net> Date: Tue, 20 Jan 2015 18:48:03 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Vivien Didelot , netdev@vger.kernel.org CC: "David S . Miller" , linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH] net: dsa: set parent of hwmon device References: <1421799212-2028-1-git-send-email-vivien.didelot@savoirfairelinux.com> In-Reply-To: <1421799212-2028-1-git-send-email-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020201.54BF1380.0133,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 11 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2015 04:13 PM, Vivien Didelot wrote: > Set the dsa device as the parent of the hwmon device, in order to link > the hwmon subsystem under the corresponding /sys/devices/platform/dsa.X/ > sysfs directory. > > Signed-off-by: Vivien Didelot > --- > net/dsa/dsa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c > index 3731714..363102a 100644 > --- a/net/dsa/dsa.c > +++ b/net/dsa/dsa.c > @@ -347,7 +347,7 @@ dsa_switch_setup(struct dsa_switch_tree *dst, int index, > hname[j] = '\0'; > scnprintf(ds->hwmon_name, sizeof(ds->hwmon_name), "%s_dsa%d", > hname, index); > - ds->hwmon_dev = hwmon_device_register_with_groups(NULL, > + ds->hwmon_dev = hwmon_device_register_with_groups(parent, > ds->hwmon_name, ds, dsa_hwmon_groups); > if (IS_ERR(ds->hwmon_dev)) > ds->hwmon_dev = NULL; > I'll have to look into this again; not sure if this works because there is no 1:1 relationship between dsa device and hwmon device (or switch chip). Guenter