From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45105)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YDrJl-00045b-JF
	for qemu-devel@nongnu.org; Wed, 21 Jan 2015 04:11:21 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YDrJg-0001gr-1Z
	for qemu-devel@nongnu.org; Wed, 21 Jan 2015 04:11:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36492)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YDrJf-0001gb-OQ
	for qemu-devel@nongnu.org; Wed, 21 Jan 2015 04:11:11 -0500
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0L9BBZ1012908
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 21 Jan 2015 04:11:11 -0500
Message-ID: <54BF6D2C.7060005@redhat.com>
Date: Wed, 21 Jan 2015 11:11:08 +0200
From: Marcel Apfelbaum <marcel@redhat.com>
MIME-Version: 1.0
References: <1421831353-5507-1-git-send-email-imammedo@redhat.com>
	<1421831353-5507-2-git-send-email-imammedo@redhat.com>
In-Reply-To: <1421831353-5507-2-git-send-email-imammedo@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 1/5] pc: acpi-build: cleanup AcpiPmInfo
	initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: marcel.a@redhat.com, mst@redhat.com

On 01/21/2015 11:09 AM, Igor Mammedov wrote:
> zero initialize AcpiPmInfo struct to reduce code bloat
> a little bit.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com>
> ---
>   hw/i386/acpi-build.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 77a124e..4c0536f 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -172,6 +172,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
>       Object *obj = NULL;
>       QObject *o;
>
> +    memset(pm, 0, sizeof(*pm));
> +
>       if (piix) {
>           obj = piix;
>       }
> @@ -184,22 +186,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
>       o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL);
>       if (o) {
>           pm->s3_disabled = qint_get_int(qobject_to_qint(o));
> -    } else {
> -        pm->s3_disabled = false;
>       }
>       qobject_decref(o);
>       o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL);
>       if (o) {
>           pm->s4_disabled = qint_get_int(qobject_to_qint(o));
> -    } else {
> -        pm->s4_disabled = false;
>       }
>       qobject_decref(o);
>       o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);
>       if (o) {
>           pm->s4_val = qint_get_int(qobject_to_qint(o));
> -    } else {
> -        pm->s4_val = false;
>       }
>       qobject_decref(o);
>
>

Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>