From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1YDrep-0006dk-KR
	for qemu-devel@nongnu.org; Wed, 21 Jan 2015 04:33:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1YDrel-0002yl-Sp
	for qemu-devel@nongnu.org; Wed, 21 Jan 2015 04:33:03 -0500
Message-ID: <54BF7249.8060002@msgid.tls.msk.ru>
Date: Wed, 21 Jan 2015 12:32:57 +0300
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1421771028-5251-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1421771028-5251-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH] sb16: fix interrupt
	acknowledgement
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: j_bair@bellsouth.net, Gerd Hoffmann <kraxel@redhat.com>, qemu-stable@nongnu.org

20.01.2015 19:23, Paolo Bonzini wrote:
> --- a/hw/audio/sb16.c
> +++ b/hw/audio/sb16.c
> @@ -999,7 +999,7 @@ static IO_READ_PROTO (dsp_read)
>          retval = (!s->out_data_len || s->highspeed) ? 0 : 0x80;
>          if (s->mixer_regs[0x82] & 1) {
>              ack = 1;
> -            s->mixer_regs[0x82] &= 1;
> +            s->mixer_regs[0x82] &= ~1;

Shouldn't it be ~1u instead?

/mjt