From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 2/3] xen/pvh: check permissions when adding MMIO regions Date: Wed, 21 Jan 2015 13:02:28 +0000 Message-ID: <54BFA364.2000105@citrix.com> References: <1421773534-15752-1-git-send-email-roger.pau@citrix.com> <1421773534-15752-3-git-send-email-roger.pau@citrix.com> <54BE9C35.7010800@citrix.com> <54BF7AAA.8090401@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YDuvZ-0003DC-By for xen-devel@lists.xenproject.org; Wed, 21 Jan 2015 13:02:33 +0000 In-Reply-To: <54BF7AAA.8090401@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , xen-devel@lists.xenproject.org Cc: Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gMjEvMDEvMTUgMTA6MDgsIFJvZ2VyIFBhdSBNb25uw6kgd3JvdGU6Cj4gRWwgMjAvMDEvMTUg YSBsZXMgMTkuMTksIEFuZHJldyBDb29wZXIgaGEgZXNjcml0Ogo+PiBPbiAyMC8wMS8xNSAxNzow NSwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOgo+Pj4gQ2hlY2sgdGhhdCBNTUlPIHJlZ2lvbnMgYWRk ZWQgdG8gUFZIIERvbTAgYXJlIGFsbG93ZWQuIFByZXZpb3VzbHkgYSBQVkggRG9tMAo+Pj4gd291 bGQgaGF2ZSBhY2Nlc3MgdG8gdGhlIGZ1bGwgTU1JTyByYW5nZS4KPj4+Cj4+PiBTaWduZWQtb2Zm LWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4KPj4+IENjOiBKYW4g QmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+Cj4+PiBDYzogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4KPj4+IC0tLQo+Pj4gQ2hhbmdlcyBzaW5jZSB2MToKPj4+ICAt IFVzZSB0aGUgbmV3bHkgaW50cm9kdWNlZCBwMm1fYWNjZXNzX3QgdG8gc2V0IHRoZSBhY2Nlc3Mg dHlwZS4KPj4+ICAtIERvbid0IGFkZCBhIG5leHQgbGFiZWwuCj4+PiAtLS0KPj4+ICB4ZW4vYXJj aC94ODYvZG9tYWluX2J1aWxkLmMgfCAxNyArKysrKysrKysrKysrKystLQo+Pj4gIDEgZmlsZSBj aGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1n aXQgYS94ZW4vYXJjaC94ODYvZG9tYWluX2J1aWxkLmMgYi94ZW4vYXJjaC94ODYvZG9tYWluX2J1 aWxkLmMKPj4+IGluZGV4IGY2ODdjNzguLjQxZDI1NDEgMTAwNjQ0Cj4+PiAtLS0gYS94ZW4vYXJj aC94ODYvZG9tYWluX2J1aWxkLmMKPj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9kb21haW5fYnVpbGQu Ywo+Pj4gQEAgLTMxOSwxMiArMzE5LDI1IEBAIHN0YXRpYyBfX2luaXQgdm9pZCBwdmhfYWRkX21l bV9tYXBwaW5nKHN0cnVjdCBkb21haW4gKmQsIHVuc2lnbmVkIGxvbmcgZ2ZuLAo+Pj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgbWZuLCB1bnNp Z25lZCBsb25nIG5yX21mbnMpCj4+PiAgewo+Pj4gICAgICB1bnNpZ25lZCBsb25nIGk7Cj4+PiAr ICAgIG1mbl90IG9tZm47Cj4+PiArICAgIHAybV90eXBlX3QgdDsKPj4+ICsgICAgcDJtX2FjY2Vz c190IGE7Cj4+PiAgICAgIGludCByYzsKPj4+ICAKPj4+ICAgICAgZm9yICggaSA9IDA7IGkgPCBu cl9tZm5zOyBpKysgKQo+Pj4gICAgICB7Cj4+PiAtICAgICAgICBpZiAoIChyYyA9IHNldF9tbWlv X3AybV9lbnRyeShkLCBnZm4gKyBpLCBfbWZuKG1mbiArIGkpLAo+Pj4gLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcDJtX2dldF9ob3N0cDJtKGQpLT5kZWZhdWx0X2FjY2Vz cykpICkKPj4+ICsgICAgICAgIGlmICggIWlvbWVtX2FjY2Vzc19wZXJtaXR0ZWQoZCwgbWZuICsg aSwgbWZuICsgaSkgKSB7Cj4+PiArICAgICAgICAgICAgb21mbiA9IGdldF9nZm5fcXVlcnlfdW5s b2NrZWQoZCwgZ2ZuICsgaSwgJnQpOwo+Pj4gKyAgICAgICAgICAgIGd1ZXN0X3BoeXNtYXBfcmVt b3ZlX3BhZ2UoZCwgZ2ZuICsgaSwgbWZuX3gob21mbiksIFBBR0VfT1JERVJfNEspOwo+Pj4gKyAg ICAgICAgICAgIGNvbnRpbnVlOwo+Pj4gKyAgICAgICAgfQo+PiBUaGlzIHN1Z2dlc3RzIGEgZGVz aWduIGZsYXcgKHBvc3NpYmx5IHByZS1leGlzdGluZykuICBXZSBzaG91bGQgbm90IGJlCj4+IHJl bW92aW5nIHBoeXNtYXAgZW50cmllcyBpbiBwdmhfYWRkX21lbV9tYXBwaW5nKCksIG5vciBzaG91 bGQgd2UgYmUgYQo+PiBwb3NpdGlvbiB0byBuZWVkIHRvIHJldm9rZSBwaHlzbWFwIGVudHJpZXMg ZHVyaW5nIGRvbWFpbiBidWlsZC4KPj4KPj4gSWYgdGhlcmUgaXMgYW55dGhpbmcgbmVlZGluZyBy ZXZva2luZyBhdCB0aGlzIHN0YWdlLCBpdCBzaG91bGQgbm90IGhhdmUKPj4gYmVlbiBhZGRlZCBl YXJsaWVyLiAgSG93IGRpZCB5b3UgY29tZSB0byBpbnRyb2R1Y2UgdGhpcyBjb2RlPwo+IFRoaXMg Y29kZSB3YXMgaW50cm9kdWNlZCB3aXRoIHRoZSBQVkggRG9tMCBzdXBwb3J0IHNlcmllcyBkb25l IGJ5Cj4gTXVrZXNoLiBCYXNpY2FsbHkgd2UgbGV0IGNvbnN0cnVjdF9kb20wIGJ1aWxkIHRoZSBw aHlzbWFwIGFzIGl0IHdvdWxkIGJlCj4gZG9uZSBmb3IgYSBQViBEb20wIChubyBob2xlcyBhdCBh bGwsIHBsYWluIHBoeXNtYXAgZnJvbSAwIHRvIG1heG1lbSkgYW5kCj4gdGhlbiB3ZSBwdW5jaCB0 aGUgTU1JTyBob2xlcyBhcyBuZWVkZWQuIEFmdGVyIHB1bmNoaW5nIHRoZSBob2xlcywgd2UgYWRk Cj4gdGhlIGxlZnRvdmVyIG1lbW9yeSB0byB0aGUgZW5kIG9mIHRoZSBtZW1vcnkgbWFwLgo+Cj4g SU1ITyB0aGlzIHNlZW1zIGJldHRlciB0aGFuIGhhdmluZyB0d28gZGlmZmVyZW50IHdheXMgb2Yg YnVpbGRpbmcgdGhlCj4gRG9tMCBtZW1vcnkgbWFwIGludGVybGVhdmVkIGluIHRoZSBjb2RlLCBv bmUgZm9yIFBWIGFuZCBvbmUgZm9yIFBWSCwKPiBzcGVjaWFsbHkgdGFraW5nIGludG8gYWNjb3Vu dCB0aGF0IHRoZSBjb2RlIGluIGNvbnN0cnVjdF9kb20wIGlzIGFscmVhZHkKPiBxdWl0ZSBjb252 b2x1dGVkLgoKUFYgZG9tYWlucyBkbyBub3QgaGF2ZSBwaHlzbWFwczsgcGh5c21hcHMgYXJlIGFu IEhWTSBjb25zdHJ1Y3QuIApBdHRlbXB0aW5nIHRvIHByZXRlbmQgdGhhdCBQViBhbmQgUFZIIGFy ZSB0aGUgc2FtZSB3aGVuIGl0IGNvbWVzIHRvCm1lbW9yeSBzZXR1cCBsaWtlIHRoaXMgaXMgYSBt aXNkZXNpZ24gYXQgYmVzdC4KCkxvb2tpbmcgdGhyb3VnaCB0aGUgY29kZSwgdGhlIG1lbW9yeSBz ZXR1cCBmb3IgUFZIIGFwcGVhcnMgY29tcGxldGVseQpiYWNrd2FyZHMsIGFuZCBzaG91bGQgYmUg Zml4ZWQgcHJvcGVybHkgcmF0aGVyIHRoYW4gaGF2aW5nIHlldCBhbm90aGVyCmhhY2sgcGxhY2Vk IG9uIHRvcC4KCkJ5IChhIHZlcnkgcnVzaGVkKSBsb29rIG9mIHRoZSBjb2RlLCBpdCBjdXJyZW50 bHkgZG9lcwoqIENvbnN0cnVjdCBQViBwYWdldGFibGVzCiogQ29uc3RydWN0IHBsYWluIHAybSBm cm9tIDAgdG8gZG9tMCBtYXggcmFtCiogV2FuZGVyIG92ZXIgUFYgcGFnZXRhYmxlcyB0cmFuc2xh dGluZyBtZm5zIHRvIHBmbnMKKiBFeHRyYSBtaXNjIHAybSBjaGFuZ2VzIGluY2x1ZGluZyBtYWtp bmcgaG9sZXMsIHNoaWZ0aW5nIHJhbSwgY2hhbmdpbmcKcGVybWlzc2lvbnMKCkEgbW9yZSBzZW5z aWJsZSBzZXR1cCB3b3VsZCBiZToKKiBTdGFydCBjb25zdHJ1Y3RpbmcgdGhlIHAybSB3aXRoIHRo ZSBpZGVudGl0eSBhbmQgYW5kIHJlYWQtb25seSBhcmVhcwoqIEluc2VydCByZWd1bGFyIHBhZ2Vz IGZyb20gMCB0byBtYXgsIHNraXBwaW5nIG92ZXIgZXhpc3RpbmcgYXJlYXMKKiBFeHRyYWN0IHRo ZSBrZXJuZWwgYW5kIGluaXRyZCBpbnRvIHAybSAodGhlIGRvbWFpbiBidWlsZGVyIGNhbgpjZXJ0 YWlubHkgZG8gdGhpcykKKiBTZXQgdXAgaWRlbnRpdHkgcGFnZXRhYmxlcyBjb3ZlcmluZyB0aGUg a2VybmVsIGFuZCBpbml0cmQKClRoaXMgd2F5LCB0aGVyZSBpcyBubyBnb2luZyBiYWNrIHRvIHVu ZG8gc29tZXRoaW5nIHdoaWNoIHdhcyBkb25lCmluY29ycmVjdGx5IGVhcmxpZXIgZHVyaW5nIGJ1 aWxkLiAgSSBwcmVzdW1lIEkgaGF2ZSBvdmVyIHNpbXBsaWZpZWQgc29tZQphcmVhcywgYnV0IEkg aG9wZSBJIGhhdmUgbWFuYWdlZCB0byBnZXQgbXkgcG9pbnQgYWNyb3NzLgoKfkFuZHJldwoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBt YWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcv eGVuLWRldmVsCg==