From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH] introduce and used relaxed cpumask
	operations
Date: Wed, 21 Jan 2015 15:10:41 +0000
Message-ID: <54BFC171.7000206@eu.citrix.com>
References: <54BD379C0200007800056965@mail.emea.novell.com>
	<54BFB775.7030702@eu.citrix.com>
	<54BFC7290200007800057BAE@mail.emea.novell.com>
	<54BFBAEA.50002@eu.citrix.com>
	<54BFCE7D0200007800057C34@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <George.Dunlap@citrix.com>) id 1YDx8C-0005J2-Io
	for xen-devel@lists.xenproject.org; Wed, 21 Jan 2015 15:23:44 +0000
In-Reply-To: <54BFCE7D0200007800057C34@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: KeirFraser <keir@xen.org>, Andrew Cooper <andrew.cooper3@citrix.com>, TimDeegan <tim@xen.org>, Ian Campbell <Ian.Campbell@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 01/21/2015 03:06 PM, Jan Beulich wrote:
>>>> On 21.01.15 at 15:42, <george.dunlap@eu.citrix.com> wrote:
>> On 01/21/2015 02:35 PM, Jan Beulich wrote:
>>>>>> On 21.01.15 at 15:28, <george.dunlap@eu.citrix.com> wrote:
>>>> On 01/19/2015 03:58 PM, Jan Beulich wrote:
>>>>> @@ -780,10 +780,7 @@ rt_schedule(const struct scheduler *ops,
>>>>>      }
>>>>>      else
>>>>>      {
>>>>> -        cpumask_t cur_cpu;
>>>>> -        cpumask_clear(&cur_cpu);
>>>>> -        cpumask_set_cpu(cpu, &cur_cpu);
>>>>> -        snext = __runq_pick(ops, &cur_cpu);
>>>>> +        snext = __runq_pick(ops, cpumask_of(cpu));
>>>>>          if ( snext == NULL )
>>>>>              snext = rt_vcpu(idle_vcpu[cpu]);
>>>>>  
>>>>
>>>> This bit really needs explicit mention in the changelog.
>>>
>>> Already done in response to Andrew's similar request.
>>
>> Ah, sorry -- I saw that but for some reason thought he was talking about
>> a different hunk.
> 
> It was indeed, be the wording I added
> 
> Note that this
> - adds a volatile qualifier to cpumask_test_and_{clear,set}_cpu()
>   (should have been there from the beginning, like is the case for
>   cpumask_{clear,set}_cpu())
> - replaces several cpumask_clear()+cpumask_set_cpu(, n) pairs by the
>   simpler cpumask_copy(, cpumask_of(n)) (or just cpumask_of(n) if we
>   can do without copying)
> 
> isn't really specific to where these changes get done (as it's a
> common pattern).

Gotcha, thanks.

 -George