Re: [PATCH v2 1/2] xen-sndfront: add sound frontend driver

[Jaroslav Kysela <perex@perex.cz>]

Dne 20.1.2015 v 10:03 Oleksandr Dmytryshyn napsal(a):
> This is Para-virtual sound driver.
> 
> Frontend driver registers an virtual sound card
> and sends an PCM streams to the backend driver.
> Backend driver is an user-space application and
> uses ALSA with dmix plugin to play audio.
> 
> Signed-off-by: Oleksandr Dmytryshyn <oleksandr.dmytryshyn@globallogic.com>
> Signed-off-by: Iurii Konovalenko <iurii.konovalenko@globallogic.com>

> +static struct snd_kcontrol_new snd_virtualcard_controls[] = {
> +VIRTUALCARD_VOLUME("Master Out Volume", 0, MIXER_ADDR_MASTER_OUT),
> +VIRTUALCARD_CAPSRC("Master Out Switch", 0, MIXER_ADDR_MASTER_OUT),
> +VIRTUALCARD_VOLUME("Master In Volume", 0, MIXER_ADDR_MASTER_IN),
> +VIRTUALCARD_CAPSRC("Master In Switch", 0, MIXER_ADDR_MASTER_IN),

Master In / Out ? Why ? I does not follow the standard naming.

I would prefer 'PCM' and 'PCM Input' or so...

					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project; Red Hat, Inc.