From: Guenter Roeck <linux@roeck-us.net>
To: Doug Anderson <dianders@chromium.org>, Wim Van Sebroeck <wim@iguana.be>
Cc: Heiko Stuebner <heiko@sntech.de>,
Lunxue Dai <lunxue.dai@rock-chips.com>,
Jisheng Zhang <jszhang@marvell.com>,
Dinh Nguyen <dinguyen@altera.com>,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] watchdog: dw_wdt: Try to get a 30 second watchdog by default
Date: Wed, 21 Jan 2015 15:36:06 -0800 [thread overview]
Message-ID: <54C037E6.1000208@roeck-us.net> (raw)
In-Reply-To: <1421882243-3631-2-git-send-email-dianders@chromium.org>
On 01/21/2015 03:17 PM, Doug Anderson wrote:
> The dw_wdt_set_top() function takes in a value in seconds. In
> dw_wdt_open() we were calling it with a value that's supposed to
> represent the maximum value programmed into the "top" register with a
> comment saying that we were trying to set the watchdog to its maximum
> value. Instead we ended up setting the watchdog to ~15 seconds.
>
> Let's fix this. However, setting things to the "max" gives me an 86
> second watchdog in the system I'm looking at. 86 seconds feels a
> little too long. We'll explicitly choose 30 seconds as a more
> reasonable value.
>
> NOTE: Ideally this driver should be transitioned to be a real watchdog
> driver. Then we could use "watchdog_init_timeout" and let the timeout
> be specified in a number of ways (device tree, module parameter, etc).
> This patch should be considered a bit of a stopgap solution.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2015-01-21 23:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 23:17 [PATCH 1/2] watchdog: dw_wdt: pat the watchdog before enabling it Doug Anderson
2015-01-21 23:17 ` [PATCH 2/2] watchdog: dw_wdt: Try to get a 30 second watchdog by default Doug Anderson
2015-01-21 23:36 ` Guenter Roeck [this message]
2015-01-21 23:35 ` [PATCH 1/2] watchdog: dw_wdt: pat the watchdog before enabling it Guenter Roeck
2015-01-22 5:22 ` Jisheng Zhang
2015-01-22 5:31 ` Guenter Roeck
2015-01-22 17:09 ` Doug Anderson
2015-01-23 16:03 ` Guenter Roeck
2015-01-23 16:20 ` Doug Anderson
2015-01-23 17:02 ` Guenter Roeck
2015-01-26 6:22 ` Jisheng Zhang
2015-01-26 17:01 ` Doug Anderson
2015-01-27 3:44 ` Jisheng Zhang
2015-01-27 4:07 ` Guenter Roeck
2015-01-27 4:36 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C037E6.1000208@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dianders@chromium.org \
--cc=dinguyen@altera.com \
--cc=heiko@sntech.de \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=lunxue.dai@rock-chips.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.