All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junxiao Bi <junxiao.bi@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 0/9 v6] ocfs2: support append O_DIRECT write
Date: Thu, 22 Jan 2015 10:10:55 +0800	[thread overview]
Message-ID: <54C05C2F.5080009@oracle.com> (raw)
In-Reply-To: <54BE1919.1000507@huawei.com>

On 01/20/2015 05:00 PM, Joseph Qi wrote:
> Hi Junxiao,
> 
> On 2015/1/20 16:26, Junxiao Bi wrote:
>> Hi Joseph,
>>
>> Did this version make any performance improvement with v5? I tested v5,
>> and it didn't improve performance with original buffer write + sync.
> No performance difference between these two versions.
> But we have tested with fio before, it shows about 5% performance
> improvement with normal buffer write (without sync).
> As I described, this feature is not truly for performance improvement.
> We aim to reduce the host page cache consumption. For example, dom0
> in virtualization case which won't be configured too much memory.
I cared the direct-io performance because recently i got a bug that
ocfs2 appending write direct-io performance was two times less than
ext4. Since you followed some idea from ext4, do you know why ext4 is
faster and any advise to improve ocfs2 performance?

Thanks,
Junxiao.
> 
> --
> Joseph
>>
>> Thanks,
>> Junxiao.
>>
>> On 01/20/2015 04:01 PM, Joseph Qi wrote:
>>> Currently in case of append O_DIRECT write (block not allocated yet),
>>> ocfs2 will fall back to buffered I/O. This has some disadvantages.
>>> Firstly, it is not the behavior as expected.
>>> Secondly, it will consume huge page cache, e.g. in mass backup scenario.
>>> Thirdly, modern filesystems such as ext4 support this feature.
>>>
>>> In this patch set, the direct I/O write doesn't fallback to buffer I/O
>>> write any more because the allocate blocks are enabled in direct I/O
>>> now.
>>>
>>> changelog:
>>> v6 <- v5:
>>> -- Take Mark's advice to use prefix "dio-" to distinguish dio orphan
>>>    entry from unlink/rename.
>>> -- Take Mark's advice to treat this feature as a ro compat feature.
>>> -- Fix a bug in case of not cluster aligned io, cluster_align should
>>>    be !zero_len, not !!zero_len.
>>> -- Fix a bug in case of fallocate with FALLOC_FL_KEEP_SIZE.
>>> -- Fix the wrong *ppos and written when completing the rest request
>>>    using buffer io.
>>>
>>> Corresponding ocfs2 tools (mkfs.ocfs2, tunefs.ocfs2, fsck.ocfs2, etc.)
>>> will be updated later.
>>>
>>>
>>> _______________________________________________
>>> Ocfs2-devel mailing list
>>> Ocfs2-devel at oss.oracle.com
>>> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
>>>
>>
>>
>>
> 
> 

  reply	other threads:[~2015-01-22  2:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20  8:01 [Ocfs2-devel] [PATCH 0/9 v6] ocfs2: support append O_DIRECT write Joseph Qi
2015-01-20  8:26 ` Junxiao Bi
2015-01-20  9:00   ` Joseph Qi
2015-01-22  2:10     ` Junxiao Bi [this message]
2015-01-22  3:54       ` Joseph Qi
2015-01-22  5:06         ` Junxiao Bi
  -- strict thread matches above, loose matches on Subject: below --
2015-08-04  6:16 Ryan Ding
2015-08-04  9:03 ` Joseph Qi
2015-08-05  4:40   ` Ryan Ding
2015-08-05  6:40     ` Joseph Qi
2015-08-05  8:07       ` Ryan Ding
2015-08-05 11:18         ` Joseph Qi
2015-08-06  2:35           ` Ryan Ding
2015-08-05  7:08     ` Joseph Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C05C2F.5080009@oracle.com \
    --to=junxiao.bi@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.