From: Li Wang <liwang@ubuntukylin.com>
To: Sage Weil <sweil@redhat.com>
Cc: Josh Durgin <josh.durgin@inktank.com>,
ceph-devel@vger.kernel.org,
Yunchuan Wen <yunchuanwen@ubuntukylin.com>
Subject: Re: [PATCH] Rbd: add listwatchers command
Date: Thu, 22 Jan 2015 12:55:20 +0800 [thread overview]
Message-ID: <54C082B8.2010807@ubuntukylin.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1501210856200.3895@cobra.newdream.net>
My thoughts, 'rbd info' is intended to describe
the STATIC, intrinsic properties of an image, while
the watchers information are dynamic, something like
'rbd showmapped', what is your opinion?
Cheers,
Li Wang
On 2015/1/22 9:35, Sage Weil wrote:
> On Wed, 21 Jan 2015, Li Wang wrote:
>> Currently, RBD does not provide an easy way to
>> consult who opened a specied image, this complicates
>> the cloud maintenance, sometimes the administrator
>> found that a RBD image could not be deleted with
>> an error 'image has watchers', but no further
>> information available. The RADOS has a command to
>> show the watchers of an object, but the commands
>> at RADOS level are not supposed to be exposed to a
>> cloud administrator, and it is not clear for a
>> non-expert administrator to how to associate an
>> opened RBD with a corresponding watched object.
>> This motivates us to add an RBD command to list the
>> information of the clients who opened a RBD image to
>> facilitate the cloud maintenance.
>
> Perhaps this should just be rolled into the existing 'rbd info' command.
> More people will see it and there's no additional cost over what info is
> already doing...
>
> sage
>
>
>
>
>
>>
>> The patches are at:
>> https://github.com/ceph/ceph/pull/3435
>>
>> Yunchuan Wen (3):
>> rbd: add listwatchers command to list the watchers of an image
>> test: add rbd listwatchers to src/test/cli/rbd/help.t
>> man: add rbd listwatchers to doc/man/8/rbd.rst
>>
>> doc/man/8/rbd.rst | 3 +++
>> src/rbd.cc | 63 +++++++++++++++++++++++++++++++++++++++++++++++--
>> src/test/cli/rbd/help.t | 1 +
>> 3 files changed, 65 insertions(+), 2 deletions(-)
>>
>> --
>> 1.9.1
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-01-22 5:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 14:32 [PATCH] Rbd: add listwatchers command Li Wang
2015-01-21 16:58 ` Sage Weil
2015-01-22 4:55 ` Li Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C082B8.2010807@ubuntukylin.com \
--to=liwang@ubuntukylin.com \
--cc=ceph-devel@vger.kernel.org \
--cc=josh.durgin@inktank.com \
--cc=sweil@redhat.com \
--cc=yunchuanwen@ubuntukylin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.