From: Olliver Schinagl <o.schinagl@ultimaker.com>
To: Rojhalat Ibrahim <imr@rtschenk.de>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Olliver Schinagl <oliver@schinagl.nl>,
Robin Gong <b38343@freescale.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Aaron Lu <aaron.lu@intel.com>,
Grant Likely <grant.likely@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Alexander Shiyan <shc_work@mail.ru>,
Wolfram Sang <wsa@the-dreams.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 4/4] leds: no longer use unnamed gpios
Date: Thu, 22 Jan 2015 10:37:46 +0100 [thread overview]
Message-ID: <54C0C4EA.5020404@ultimaker.com> (raw)
In-Reply-To: <2355733.gZvsF3iKWH@pcimr>
Hey Rojhalat,
On 22-01-15 10:32, Rojhalat Ibrahim wrote:
> On Wednesday 21 January 2015 22:33:48 Olliver Schinagl wrote:
>> From: Olliver Schinagl <oliver@schinagl.nl>
>>
>> The gpio document says we should not use unnamed bindings for gpios.
>> This patch uses the 'led-' prefix to the gpios and updates code and
>> documents. Because the devm_get_gpiod_from_child() falls back to using
>> old-style unnamed gpios, we can update the code first, and update
>> dts files as time allows.
>>
>> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> Where does devm_get_gpiod_from_child() fall back "to using old-style
> unnamed gpios"?
Your absolutly right, I accidentally forgot a patch that was supposed to
get squashed into this patchset. The idea is to do the same as in
gpio-keys-polled.c. I'll make sure it sits in v3 of the set! My appologies!
Olliver
>
> After applying this patch the leds defined in my devicetree do not
> work anymore.
>
> Rojhalat
>
>
>
--
Met vriendelijke groeten, Kind regards, 与亲切的问候
Olliver Schinagl
Research & Development
Ultimaker B.V.
http://www.ultimaker.com
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Olliver Schinagl <o.schinagl@ultimaker.com>
To: Rojhalat Ibrahim <imr@rtschenk.de>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
Olliver Schinagl <oliver@schinagl.nl>,
Robin Gong <b38343@freescale.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Aaron Lu <aaron.lu@intel.com>,
Grant Likely <grant.likely@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Alexander Shiyan <shc_work@mail.ru>,
Wolfram Sang <wsa@the-dreams.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 4/4] leds: no longer use unnamed gpios
Date: Thu, 22 Jan 2015 10:37:46 +0100 [thread overview]
Message-ID: <54C0C4EA.5020404@ultimaker.com> (raw)
In-Reply-To: <2355733.gZvsF3iKWH@pcimr>
Hey Rojhalat,
On 22-01-15 10:32, Rojhalat Ibrahim wrote:
> On Wednesday 21 January 2015 22:33:48 Olliver Schinagl wrote:
>> From: Olliver Schinagl <oliver@schinagl.nl>
>>
>> The gpio document says we should not use unnamed bindings for gpios.
>> This patch uses the 'led-' prefix to the gpios and updates code and
>> documents. Because the devm_get_gpiod_from_child() falls back to using
>> old-style unnamed gpios, we can update the code first, and update
>> dts files as time allows.
>>
>> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
> Where does devm_get_gpiod_from_child() fall back "to using old-style
> unnamed gpios"?
Your absolutly right, I accidentally forgot a patch that was supposed to
get squashed into this patchset. The idea is to do the same as in
gpio-keys-polled.c. I'll make sure it sits in v3 of the set! My appologies!
Olliver
>
> After applying this patch the leds defined in my devicetree do not
> work anymore.
>
> Rojhalat
>
>
>
--
Met vriendelijke groeten, Kind regards, 与亲切的问候
Olliver Schinagl
Research & Development
Ultimaker B.V.
http://www.ultimaker.com
next prev parent reply other threads:[~2015-01-22 9:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 21:33 [PATCH v2 0/4] Let leds use named gpios Olliver Schinagl
2015-01-21 21:33 ` [PATCH v2 1/4] gpio: use sizeof() instead of hardcoded values Olliver Schinagl
2015-01-30 13:43 ` Linus Walleij
2015-01-30 13:43 ` Linus Walleij
2015-01-21 21:33 ` [PATCH v2 2/4] gpio: add parameter to allow the use named gpios Olliver Schinagl
2015-01-30 13:46 ` Linus Walleij
2015-01-30 19:12 ` Bryan Wu
2015-01-30 19:12 ` Bryan Wu
2015-01-30 22:16 ` Dmitry Torokhov
2015-01-30 22:16 ` Dmitry Torokhov
2015-01-30 22:22 ` Dmitry Torokhov
2015-01-30 22:22 ` Dmitry Torokhov
2015-02-09 5:24 ` Alexandre Courbot
2015-02-09 5:24 ` Alexandre Courbot
[not found] ` <1421876028-22799-3-git-send-email-o.schinagl-U3FVU11NWA554TAoqtyWWQ@public.gmane.org>
2015-03-04 13:00 ` Linus Walleij
2015-03-04 13:00 ` Linus Walleij
2015-01-21 21:33 ` [PATCH v2 3/4] leds: Let the binding document example for leds-gpio follow the gpio bindings Olliver Schinagl
2015-03-02 11:24 ` Linus Walleij
2015-03-02 11:24 ` Linus Walleij
2015-03-02 20:03 ` Bryan Wu
2015-03-02 20:03 ` Bryan Wu
2015-01-21 21:33 ` [PATCH v2 4/4] leds: no longer use unnamed gpios Olliver Schinagl
2015-01-22 9:32 ` Rojhalat Ibrahim
2015-01-22 9:37 ` Olliver Schinagl [this message]
2015-01-22 9:37 ` Olliver Schinagl
2015-01-22 16:33 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C0C4EA.5020404@ultimaker.com \
--to=o.schinagl@ultimaker.com \
--cc=aaron.lu@intel.com \
--cc=b38343@freescale.com \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=imr@rtschenk.de \
--cc=jg1.han@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=oliver@schinagl.nl \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=shc_work@mail.ru \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.