From: Li Bin <huawei.libin@huawei.com>
To: Miroslav Benes <mbenes@suse.cz>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jkosina@suse.cz>, Vojtech Pavlik <vojtech@suse.cz>,
Jiri Slaby <jslaby@suse.cz>, <live-patching@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lizefan@huawei.com>,
<guohanjun@huawei.com>, <zhangdianfang@huawei.com>,
<xiexiuqi@huawei.com>
Subject: Re: [PATCH 1/2] livepatch: Revert "livepatch: enforce patch stacking semantics"
Date: Thu, 22 Jan 2015 17:42:04 +0800 [thread overview]
Message-ID: <54C0C5EC.9080507@huawei.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1501221013580.24802@pobox.suse.cz>
On 2015/1/22 17:15, Miroslav Benes wrote:
> On Thu, 22 Jan 2015, Li Bin wrote:
>
>> On 2015/1/21 17:07, Li Bin wrote:
>>> This reverts commit 83a90bb1345767f0cb96d242fd8b9db44b2b0e17.
>>>
>>> The method that only allowing the topmost patch on the stack to be
>>> enabled or disabled is unreasonable. Such as the following case:
>>>
>>> - do live patch1
>>> - disable patch1
>>> - do live patch2 //error
>>>
>>> Now, we will never be able to do new live patch unless disabing the
>>> patch1 although there is no dependencies.
>>>
>>
>> Correct the log:
>> ... unless disabling the patch1 although ... -->
>> ... unless enabling the patch1 firstly although ...
>
> Yes, but in such situation you can unregister patch1 and proceed with new
> live patch. No problem. As Jiri has already written. Or are we missing
> something?
>
Ok, that is before process with new live patch we must unregister the disabled
patch1 previously. Is there need some message to avoid confusing the user?
Thanks,
Li Bin
> Regards,
> --
> Miroslav Benes
> SUSE Labs
> --
> To unsubscribe from this list: send the line "unsubscribe live-patching" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> .
>
next prev parent reply other threads:[~2015-01-22 9:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 9:07 [PATCH 0/2] disable/enable_patch manners for interdependent patches Li Bin
2015-01-21 9:07 ` [PATCH 1/2] livepatch: Revert "livepatch: enforce patch stacking semantics" Li Bin
2015-01-21 14:06 ` Jiri Kosina
2015-01-21 14:36 ` Seth Jennings
2015-01-22 0:44 ` Li Bin
2015-01-22 1:01 ` Li Bin
2015-01-22 9:15 ` Miroslav Benes
2015-01-22 9:42 ` Li Bin [this message]
2015-01-21 9:07 ` [PATCH 2/2] livepatch: disable/enable_patch manners for interdependent patches Li Bin
2015-01-21 14:08 ` Jiri Kosina
2015-01-22 0:42 ` Li Bin
2015-01-22 3:51 ` Josh Poimboeuf
2015-01-22 8:39 ` Li Bin
2015-01-22 9:54 ` Li Bin
2015-01-22 13:05 ` Josh Poimboeuf
2015-01-23 1:08 ` Li Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C0C5EC.9080507@huawei.com \
--to=huawei.libin@huawei.com \
--cc=guohanjun@huawei.com \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mbenes@suse.cz \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
--cc=xiexiuqi@huawei.com \
--cc=zhangdianfang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.