From: Oded Gabbay <oded.gabbay@amd.com>
To: "Zhou, Jammy" <Jammy.Zhou@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/amdkfd: Handle case of invalid queue type
Date: Thu, 22 Jan 2015 12:28:29 +0200 [thread overview]
Message-ID: <54C0D0CD.1000008@amd.com> (raw)
In-Reply-To: <FD5696F5CDD4B04D92C97DB96167DECA16035CB1@SCYBEXDAG04.amd.com>
On 01/22/2015 12:28 PM, Zhou, Jammy wrote:
> Patches are Reviewed-by: Jammy Zhou <Jammy.Zhou@amd.com>
>
> Regards,
> Jammy
>
Thanks!
Oded
> -----Original Message-----
> From: dri-devel [mailto:dri-devel-bounces@lists.freedesktop.org] On Behalf Of Gabbay, Oded
> Sent: Thursday, January 22, 2015 5:42 PM
> To: dri-devel@lists.freedesktop.org
> Subject: [PATCH 3/3] drm/amdkfd: Handle case of invalid queue type
>
> This patch handles a case where amdkfd tries to destroy a queue but the queue type is invalid.
> This case occurs in non-HWS path.
>
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 85387c8..99e2dbb 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -301,6 +301,11 @@ static int destroy_queue_nocpsch(struct device_queue_manager *dqm,
> }
> dqm->sdma_queue_count--;
> deallocate_sdma_queue(dqm, q->sdma_id);
> + } else {
> + pr_debug("q->properties.type is invalid (%d)\n",
> + q->properties.type);
> + retval = -EINVAL;
> + goto out;
> }
>
> retval = mqd->destroy_mqd(mqd, q->mqd,
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-01-22 10:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 9:42 [PATCH 1/3] drm/amdkfd: Remove negative check of uint variable Oded Gabbay
2015-01-22 9:42 ` [PATCH 2/3] drm/amdkfd: Add break at the end of case Oded Gabbay
2015-01-22 9:42 ` [PATCH 3/3] drm/amdkfd: Handle case of invalid queue type Oded Gabbay
2015-01-22 10:28 ` Zhou, Jammy
2015-01-22 10:28 ` Oded Gabbay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C0D0CD.1000008@amd.com \
--to=oded.gabbay@amd.com \
--cc=Jammy.Zhou@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.