From: Paolo Bonzini <pbonzini@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] sparse: Fix build with sparse on .S files
Date: Thu, 22 Jan 2015 14:58:21 +0100 [thread overview]
Message-ID: <54C101FD.2050006@redhat.com> (raw)
In-Reply-To: <1421920426-16878-1-git-send-email-borntraeger@de.ibm.com>
On 22/01/2015 10:53, Christian Borntraeger wrote:
> rules.mak has a rule for .S files using CPP. This will result in
> errors like
> CPP s390-ccw/start.asm
> cc: error: unrecognized command line option '-Wbitwise'
>
> Lets also redefine CPP in case of --enable-sparse.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 47048f0..3bdda2e 100755
> --- a/configure
> +++ b/configure
> @@ -4909,6 +4909,7 @@ echo "QEMU_CFLAGS=$QEMU_CFLAGS" >> $config_host_mak
> echo "QEMU_INCLUDES=$QEMU_INCLUDES" >> $config_host_mak
> if test "$sparse" = "yes" ; then
> echo "CC := REAL_CC=\"\$(CC)\" cgcc" >> $config_host_mak
> + echo "CPP := REAL_CC=\"\$(CPP)\" cgcc" >> $config_host_mak
> echo "CXX := REAL_CC=\"\$(CXX)\" cgcc" >> $config_host_mak
> echo "HOST_CC := REAL_CC=\"\$(HOST_CC)\" cgcc" >> $config_host_mak
> echo "QEMU_CFLAGS += -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-non-pointer-null" >> $config_host_mak
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2015-01-22 13:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 9:53 [Qemu-devel] [PATCH] sparse: Fix build with sparse on .S files Christian Borntraeger
2015-01-22 13:58 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C101FD.2050006@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.