Re: [PATCH 7/7 v8] can/peak_usb: add support for PEAK new CANFD USB adapters

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1499 bytes --]

On 01/22/2015 04:24 PM, Stephane Grosjean wrote:
> Add support for the following new PEAK-System technik CANFD USB adapters:
> 
> PCAN-USB FD             single CANFD channel USB adapter
> PCAN-USB Pro FD         dual CANFD channels USB adapter
> 
> Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

[...]

> diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c
> new file mode 100644
> index 0000000..2129549
> --- /dev/null
> +++ b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c

[...]

> +/* handle device specific info used by the netdevices */
> +struct pcan_usb_fd_if {
> +	struct peak_usb_device *dev[PCAN_USB_MAX_CHANNEL];
> +	struct pcan_ufd_fw_info fw_info;
> +	struct peak_time_ref    time_ref;
> +	int                     cm_ignore_count;
> +	int                     dev_opened_count;

Please use tab for indention, not space.

> +};
> +
> +/* device information */
> +struct pcan_usb_fd_device {
> +	struct peak_usb_device  dev;
> +	struct can_berr_counter bec;
> +	struct pcan_usb_fd_if  *usb_if;
> +	u8                     *cmd_buffer_addr;

dito

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]