From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephane Grosjean Subject: Re: [PATCH 7/7 v8] can/peak_usb: add support for PEAK new CANFD USB adapters Date: Thu, 22 Jan 2015 16:59:06 +0100 Message-ID: <54C11E4A.3090303@peak-system.com> References: <1421940266-6088-1-git-send-email-s.grosjean@peak-system.com> <1421940266-6088-8-git-send-email-s.grosjean@peak-system.com> <54C11A1B.4090100@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail.peak-system.com ([213.157.13.214]:42898 "EHLO mail.peak-system.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752363AbbAVP7O (ORCPT ); Thu, 22 Jan 2015 10:59:14 -0500 In-Reply-To: <54C11A1B.4090100@pengutronix.de> Sender: linux-can-owner@vger.kernel.org List-ID: To: Marc Kleine-Budde , linux-can@vger.kernel.org Cc: Oliver Hartkopp Le 22/01/2015 16:41, Marc Kleine-Budde a =C3=A9crit : > On 01/22/2015 04:24 PM, Stephane Grosjean wrote: >> Add support for the following new PEAK-System technik CANFD USB adap= ters: >> >> PCAN-USB FD single CANFD channel USB adapter >> PCAN-USB Pro FD dual CANFD channels USB adapter >> >> Signed-off-by: Stephane Grosjean >> Signed-off-by: Marc Kleine-Budde > [...] > >> diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_fd.c b/drivers/ne= t/can/usb/peak_usb/pcan_usb_fd.c >> new file mode 100644 >> index 0000000..2129549 >> --- /dev/null >> +++ b/drivers/net/can/usb/peak_usb/pcan_usb_fd.c > [...] > >> +/* handle device specific info used by the netdevices */ >> +struct pcan_usb_fd_if { >> + struct peak_usb_device *dev[PCAN_USB_MAX_CHANNEL]; >> + struct pcan_ufd_fw_info fw_info; >> + struct peak_time_ref time_ref; >> + int cm_ignore_count; >> + int dev_opened_count; > Please use tab for indention, not space. > >> +}; >> + >> +/* device information */ >> +struct pcan_usb_fd_device { >> + struct peak_usb_device dev; >> + struct can_berr_counter bec; >> + struct pcan_usb_fd_if *usb_if; >> + u8 *cmd_buffer_addr; > dito > > Marc > Well, I'm afraid I have misunderstood one of your previous reMarks: > +/* device information */ > +struct pcan_usb_fd_device { > + struct peak_usb_device dev; > + struct pcan_usb_fd_if * usb_if; > struct pcan_usb_fd_if *usb_if >> + >> + u8 * cmd_buffer_addr; > u8 *cmd_buffer_addr >> + >> + uint tx_error_counter; >> + uint rx_error_counter; > unsigned int > > Please don't use a tab after the struct foo, u8, unsinged int, etc...= , > as it doesn't align. > can u explain a bit more, please ? FYI, checkpatch.pl doesn't see any=20 warning nor fatal in these indentations... St=C3=A9phane -- PEAK-System Technik GmbH Sitz der Gesellschaft Darmstadt Handelsregister Darmstadt HRB 9183=20 Geschaeftsfuehrung: Alexander Gach, Uwe Wilhelm --