All of lore.kernel.org
 help / color / mirror / Atom feed
From: Slava Monich <slava.monich@jolla.com>
To: ofono@ofono.org
Subject: Re: [PATCH] gprs: Setup route for mmsc if there's no mms proxy
Date: Thu, 22 Jan 2015 23:53:18 +0200	[thread overview]
Message-ID: <54C1714E.6070403@jolla.com> (raw)
In-Reply-To: <1420546359-7977-1-git-send-email-slava.monich@jolla.com>

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]


> And don't setup mms route at all if mmsc/proxy host name is not in
> dotted IPv4 format.
> ---
>   src/gprs.c | 25 ++++++++++++++++++++-----
>   1 file changed, 20 insertions(+), 5 deletions(-)

Sorry, somehow I missed the reply to this patch and just accidentally 
found it (the reply) at mail-archive.com.

This patch has to do the the case when no MessageProxy is provided for 
the MMS context. In that case ofono would set up host route for 
255.255.255.255 (INADDR_NONE returned by inet_addr for the empty string) 
for the MMS interface when it comes up.

With these changes the whole thing has a chance to work if MessageCenter 
URL contains IP address in the host part. In any case, configuring host 
route for 255.255.255.255 doesn't make any sense.

Regards,
-Slava

      parent reply	other threads:[~2015-01-22 21:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 12:12 [PATCH] gprs: Setup route for mmsc if there's no mms proxy Slava Monich
2015-01-06 16:19 ` Marcel Holtmann
2015-01-22 21:53 ` Slava Monich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C1714E.6070403@jolla.com \
    --to=slava.monich@jolla.com \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.